<div dir="ltr"><div>Thanks for fixing this.</div><div>I will try to not submit fixes from wrong image again</div><div><br></div><div>Best,</div><div>Karl</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Aug 10, 2022 at 10:18 AM Marcel Taeumel <<a href="mailto:marcel.taeumel@hpi.de">marcel.taeumel@hpi.de</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div id="gmail-m_551373995691105019__MailbirdStyleContent" style="font-size:10pt;font-family:Arial;color:rgb(0,0,0);text-align:left" dir="ltr">
Hi Karl --<div><br></div><div>Merged. Please avoid stacking unrelated inbox contributions on top of your previous inbox versions. Always base your inbox submission on a recent version from Trunk. kfr.530, kfr.529, and kfr.528 are all different things, yet, their ancestry depends on each other. Makes reviewing and merging more difficult. Thanks. :-)</div><div><br></div><div>Best,</div><div>Marcel</div><div></div>
<blockquote type="cite" style="border-left-style:solid;border-width:1px;margin-top:20px;margin-left:0px;padding-left:10px;min-width:500px">
<p style="color:rgb(170,170,170);margin-top:10px">Am 09.08.2022 07:12:43 schrieb <a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a> <<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>>:</p><div style="font-family:Arial,Helvetica,sans-serif">A new version of Graphics was added to project The Inbox:<br><a href="http://source.squeak.org/inbox/Graphics-kfr.530.mcz" target="_blank">http://source.squeak.org/inbox/Graphics-kfr.530.mcz</a><br><br>==================== Summary ====================<br><br>Name: Graphics-kfr.530<br>Author: kfr<br>Time: 9 August 2022, 7:12:20.983085 am<br>UUID: ee4a3ab4-fc38-f349-b0bc-f6f109ba9d01<br>Ancestors: Graphics-kfr.529<br><br>Avoid call to allButFirstDo: in Rectangle class>>encompassing: and Rectangle class>>merging:. <br>But keep the call to Rectangle class>>origin: corner: so subclasses can use these methods<br><br>=============== Diff against Graphics-kfr.529 ===============<br><br>Item was changed:<br> ----- Method: Rectangle class>>encompassing: (in category 'instance creation') -----<br> encompassing: listOfPoints<br> "A number of callers of encompass: should use this method."<br> | topLeft bottomRight |<br>+ topLeft := bottomRight := nil.<br>+ listOfPoints do:<br>+ [:p | topLeft == nil<br>+ ifTrue: [topLeft := bottomRight := p]<br>+ ifFalse: [topLeft := topLeft min: p.<br>+ bottomRight := bottomRight max: p]].<br>+ ^self origin: topLeft corner: bottomRight!<br>- topLeft := bottomRight := listOfPoints first.<br>- listOfPoints allButFirstDo:<br>- [:p |topLeft := topLeft min: p.<br>- bottomRight := bottomRight max: p].<br>- ^self origin: topLeft corner: bottomRight<br>- !<br><br>Item was changed:<br> ----- Method: Rectangle class>>merging: (in category 'instance creation') -----<br> merging: listOfRects <br> "A number of callers of merge: should use this method."<br>+ | minX minY maxX maxY |<br>- | bottomRight topLeft |<br>- topLeft := listOfRects first topLeft.<br>- bottomRight := listOfRects first bottomRight.<br> listOfRects<br>+ do: [:r | minX<br>+ ifNil: [minX := r topLeft x. minY := r topLeft y.<br>+ maxX := r bottomRight x. maxY := r bottomRight y]<br>+ ifNotNil: [minX := minX min: r topLeft x. minY := minY min: r topLeft y.<br>+ maxX := maxX max: r bottomRight x. maxY := maxY max: r bottomRight y]].<br>+ ^self origin: minX@minY corner: maxX@maxY!<br>- allButFirstDo: [:r | topLeft := topLeft min: r topLeft.<br>- bottomRight := bottomRight max: r bottomRight].<br>- ^self origin: topLeft corner: bottomRight.<br>- !<br><br><br></div></blockquote></div><br>
</blockquote></div>