<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<p>Hi Jakob,</p>
<p><br>
</p>
<p>thank you for questioning my statements from my previous post!</p>
<p><br>
</p>
<p>> <span style="font-size:12pt">Question 1: does PackageInfo even find classes and methods of MyPackage in the category OurPackage? If not, then this feature that the Monticello package can contain "adopted" categories could not work.</span></p>
<div>> <span>Question 2: since when does MyPackageTest belong into package MyPackage unless the feature from Question 1 is used? Can you give concrete examples where this is the case (and works)?</span></div>
<div><br>
</div>
<div>No, it doesn't. I was wrong. See <span>PackageInfo>>#category:matches:. The system category needs to start with the package name, but case-insensitively, followed by a dash. So </span><span style="font-size:12pt">for package MyPackage, valid system categories
include only MyPackage-Core but NOT MyPackage, MyPackageTests, and OurPackage.</span></div>
<div><span style="font-size:12pt"><br>
</span></div>
<div><span style="font-size:12pt">This changes everything (well, not everything, but it simplifies the task of the PackagePaneBrowser). Please see <span>Tools-ct.1177 (trunk) for the next revision of the
<span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;">
PackagePaneBrowser. Looking forward to your feedback! :-)</span></span></span></div>
<div><span style="font-size:12pt"><span><span style="font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols; font-size: 16px;"><br>
</span></span></span></div>
<div>Best,</div>
<div>Christoph</div>
<div><span style="font-size:12pt"><br>
</span></div>
<p></p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von Jakob Reschke <jakres+squeak@gmail.com><br>
<b>Gesendet:</b> Mittwoch, 14. September 2022 08:51:22<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: Tools-ct.1173.mcz</font>
<div> </div>
</div>
<div>
<div dir="ltr">Hi Christoph,
<div><br>
</div>
<div>Not thinking of the effort for the moment, here is my opinion:</div>
<div>The Browser already serves its purpose. There is no need for the Package Browser to mimic it.</div>
<div>Therefore it makes more sense for the Package Browser to correctly present the system decomposition into packages. That means, do display extensions and do display "adopted" categories like OurPackage in MyPackage.</div>
<div>This implies that it becomes closer to the MCSnapshotBrowser in presentation.</div>
<div><br>
</div>
<div>Question 1: does PackageInfo even find classes and methods of MyPackage in the category OurPackage? If not, then this feature that the Monticello package can contain "adopted" categories could not work.</div>
<div>Question 2: since when does MyPackageTest belong into package MyPackage unless the feature from Question 1 is used? Can you give concrete examples where this is the case (and works)?</div>
<div><br>
</div>
<div>Kind regards,<br>
Jakob</div>
<div><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">Am Di., 13. Sept. 2022 um 14:34 Uhr schrieb Thiede, Christoph <<a href="mailto:Christoph.Thiede@student.hpi.uni-potsdam.de">Christoph.Thiede@student.hpi.uni-potsdam.de</a>>:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div class="msg1853701227344660622">
<div dir="ltr">
<div id="m_-976357384760987522divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<div id="m_-976357384760987522divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<p>Hi all,</p>
<p><br>
</p>
<p>geez, I seem to have opened a can of worms with that change to the package browser. In the past, it was just a normal browser that splits up the system category into two parts. Now, I have -- yet inconsistently -- switched it to use the actual package artifacts.
However, these package artifacts do not match the system categories-classes structure completely:</p>
<p><br>
</p>
<p></p>
<ul style="margin-bottom:0px; margin-top:0px">
<li>A package may have system categories that do not have the package name as their prefixes. E.g., for package MyPackage, valid system categories include not only MyPackage-Core, but also MyPackage, MyPackageTests, and OurPackage.</li><li>A package may have extension methods that belong to extension classes that are not defined by the package itself.</li></ul>
<p></p>
<div id="m_-976357384760987522divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<br>
</div>
So the question is, how should the package browser deal with these artifacts?</div>
<div id="m_-976357384760987522divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols">
<br>
</div>
<div id="m_-976357384760987522divtagdefaultwrapper" dir="ltr">
<ul style="margin-bottom:0px; margin-top:0px">
<li style="color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size:12pt">
Should it rather mimic the <span>MCSnapshotBrowser as much as possible, including a display for extension methods?</span></li><li style="color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size:12pt">
<span>Or should it stick with the idea of a traditional browser, do not display extension methods, and</span>
<ul style="color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size:12pt">
<li><span>just show matching system categories?</span></li><li><span>or also show the system categories for all other classes contained in the package?</span></li></ul>
</li><li>Or should we better revert the recent change and stick with a "package browser" that is actually a "hierarchical system category browser"?</li><li>Or yet something else?</li></ul>
<div><br>
</div>
<div>If it helps, we can also add a "browse package snapshot" item to the package menu of browsers (similar to what Squit's commit dialog's #<span>browseOriginalEdition:</span> offers). This would bring up what I think Tobias was asking for:</div>
<div><br>
</div>
<div><span>(MCSnapshotBrowser forSnapshot: Morph packageInfo mcPackage snapshot) showLabelled: 'Snapshot of package'.</span><br>
</div>
<div><span><br>
</span></div>
<div><span><img naturalheight="400" naturalwidth="652" size="45162" id="m_-976357384760987522img965165" style="max-width: 99.9%; user-select: none;" src="cid:1833aba0a15f456b1e51"><br>
</span></div>
<div><span><br>
</span></div>
<div><span>So, looking forward to your opinions and arguments!</span></div>
<div><span><br>
</span></div>
<div><span>Best,</span></div>
<div><span>Christoph</span></div>
<br>
<div style="color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols; font-size:12pt">
<div>
<hr style="display:inline-block; width:98%">
<div id="m_-976357384760987522x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>Von:</b> Squeak-dev <<a href="mailto:squeak-dev-bounces@lists.squeakfoundation.org" target="_blank">squeak-dev-bounces@lists.squeakfoundation.org</a>>
im Auftrag von Tobias Pape <<a href="mailto:Das.Linux@gmx.de" target="_blank">Das.Linux@gmx.de</a>><br>
<b>Gesendet:</b> Montag, 12. September 2022 23:24 Uhr<br>
<b>An:</b> The general-purpose Squeak developers list<br>
<b>Betreff:</b> Re: [squeak-dev] The Trunk: Tools-ct.1173.mcz</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt">
<div><br>
<br>
> On 12. Sep 2022, at 22:14, Thiede, Christoph <<a href="mailto:Christoph.Thiede@student.hpi.uni-potsdam.de" target="_blank">Christoph.Thiede@student.hpi.uni-potsdam.de</a>> wrote:<br>
> <br>
> Hi Tobias, Hi Karl,<br>
> <br>
> > > I noticed a few packages are empty:<br>
> > > Etoys, MonticelloForTraits, MonticelloMocks, ST80Tools, SUnitsTools, WebClient-HTTP, XML-Explorer<br>
> > <br>
> > Yeah, these only carry extension methods…<br>
> <br>
> Yes. EToys is interesting, though, as it reveals that PackagePaneBrowser>>#systemCategoryList still uses an insufficient substring mechanism. I will revise that in the next few days. Sorry for the inconvenience.<br>
> <br>
> > …which you can _currently_ only find out via the monticello browser. :(<br>
> <br>
> There is "browse extensions" in the browsers' class list/package menu. :-)<br>
<br>
Which is _different_ from the way the monticello browser displays it…<br>
<br>
:D<br>
<br>
> <br>
> <pastedImage.png><br>
> <br>
> Best,<br>
> Christoph<br>
> Von: Squeak-dev <<a href="mailto:squeak-dev-bounces@lists.squeakfoundation.org" target="_blank">squeak-dev-bounces@lists.squeakfoundation.org</a>> im Auftrag von Tobias Pape <<a href="mailto:Das.Linux@gmx.de" target="_blank">Das.Linux@gmx.de</a>><br>
> Gesendet: Montag, 12. September 2022 21:58:27<br>
> An: The general-purpose Squeak developers list<br>
> Betreff: Re: [squeak-dev] The Trunk: Tools-ct.1173.mcz<br>
> <br>
> Hi<br>
> <br>
> <br>
> > On 12. Sep 2022, at 21:41, karl ramberg <<a href="mailto:karlramberg@gmail.com" target="_blank">karlramberg@gmail.com</a>> wrote:<br>
> > <br>
> > <br>
> > I noticed a few packages are empty:<br>
> > Etoys, MonticelloForTraits, MonticelloMocks, ST80Tools, SUnitsTools, WebClient-HTTP, XML-Explorer<br>
> <br>
> Yeah, these only carry extension methods…<br>
> <br>
> …which you can _currently_ only find out via the monticello browser. :(<br>
> <br>
> Best regards<br>
> -Tobias<br>
> <br>
> > <br>
> > Best,<br>
> > Karl<br>
> > <br>
> > On Mon, Sep 12, 2022 at 7:12 PM <<a href="mailto:commits@source.squeak.org" target="_blank">commits@source.squeak.org</a>> wrote:<br>
> > Christoph Thiede uploaded a new version of Tools to project The Trunk:<br>
> > <a href="http://source.squeak.org/trunk/Tools-ct.1173.mcz" id="m_-976357384760987522LPlnk206214" target="_blank">
http://source.squeak.org/trunk/Tools-ct.1173.mcz</a><br>
> > <br>
> > ==================== Summary ====================<br>
> > <br>
> > Name: Tools-ct.1173<br>
> > Author: ct<br>
> > Time: 8 September 2022, 3:05:12.665836 pm<br>
> > UUID: f0fe2b64-b27c-6d4b-9670-d920d0580baf<br>
> > Ancestors: Tools-ct.1171<br>
> > <br>
> > Fixes package pane browser to actually use the package organizer instead of parsing the system category list. Resolves
<a href="https://github.com/squeak-smalltalk/squeak-object-memory/issues/28" id="m_-976357384760987522LPlnk45486" target="_blank">
https://github.com/squeak-smalltalk/squeak-object-memory/issues/28</a>.<br>
> > <br>
> > =============== Diff against Tools-ct.1171 ===============<br>
> > <br>
> > Item was changed:<br>
> > Browser subclass: #PackagePaneBrowser<br>
> > + instanceVariableNames: 'packageOrganizer package packageListIndex packageList'<br>
> > - instanceVariableNames: 'package packageListIndex packageList'<br>
> > classVariableNames: ''<br>
> > poolDictionaries: ''<br>
> > category: 'Tools-Browser'!<br>
> > <br>
> > + !PackagePaneBrowser commentStamp: 'ct 9/8/2022 15:05' prior: 0!<br>
> > + A package browser represents a hierarchical query path through an organization of class and method information. It nests classes into a two-level hierarchy that consists of the package (e.g., Kernel, FFI-Kernel) and the system category (e.g., Exception,
Exceptions-Kernel; Support, empty).<br>
> > - !PackagePaneBrowser commentStamp: '<historical>' prior: 0!<br>
> > - A package browser represents a hierarchical query path through an organization of class and method information. It parses class categories into a two-level hierarchy on the first '-' character, giving "packages" (e.g., Magnitude, Collections, Graphics,
etc.), and "categories" (e.g., Magnitude-General and Magnitude-Number).<br>
> > <br>
> > Instance Variables:<br>
> > + packageOrganizer <PackageOrganizer> the organizer of packages in the current environment<br>
> > package <Symbol> the "category header," e.g., #Magnitudes or #Collections<br>
> > packageListIndex <Integer> The index in the package list<br>
> > + packageList <OrderedCollection of String> the list of package names!<br>
> > - packageList <OrderedCollection of String> the list of package names<br>
> > - !<br>
> > <br>
> > Item was added:<br>
> > + ----- Method: PackagePaneBrowser>>initialize (in category 'initialize-release') -----<br>
> > + initialize<br>
> > + <br>
> > + super initialize.<br>
> > + <br>
> > + self packageOrganizer: self environment packageOrganizer.!<br>
> > <br>
> > Item was changed:<br>
> > ----- Method: PackagePaneBrowser>>packageList (in category 'package list') -----<br>
> > packageList<br>
> > - "Answer a list of the packages in the current system organization."<br>
> > <br>
> > + ^ self packageOrganizer packageNames sorted!<br>
> > - | str stream |<br>
> > - str := Set new: 100.<br>
> > - stream := WriteStream on: (Array new: 100).<br>
> > - systemOrganizer categories do:<br>
> > - [ :categ | | cats | <br>
> > - cats := categ asString copyUpTo: $-.<br>
> > - (str includes: cats) ifFalse: <br>
> > - [str add: cats.<br>
> > - stream nextPut: cats]].<br>
> > - ^stream contents!<br>
> > <br>
> > Item was added:<br>
> > + ----- Method: PackagePaneBrowser>>packageOrganizer (in category 'accessing') -----<br>
> > + packageOrganizer<br>
> > + <br>
> > + ^ packageOrganizer!<br>
> > <br>
> > Item was added:<br>
> > + ----- Method: PackagePaneBrowser>>packageOrganizer: (in category 'initialize-release') -----<br>
> > + packageOrganizer: aPackageOrganizer<br>
> > + <br>
> > + packageOrganizer := aPackageOrganizer.<br>
> > + <br>
> > + self systemOrganizer: self systemOrganizer. "reset selections"!<br>
> > <br>
> > Item was added:<br>
> > + ----- Method: PackagePaneBrowser>>selectEnvironment: (in category 'accessing') -----<br>
> > + selectEnvironment: anEnvironment<br>
> > + <br>
> > + super selectEnvironment: anEnvironment.<br>
> > + self packageOrganizer: anEnvironment packages.!<br>
> > <br>
> > <br>
> > <br>
> <br>
> <br>
> <br>
> <pastedImage.png><br>
<br>
<br>
<br>
</div>
</span></font></div>
</div>
</div>
</div>
<br>
</div>
</blockquote>
</div>
</div>
</div>
</body>
</html>