<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div id="__MailbirdStyleContent" style="font-size: 10pt;font-family: Arial;color: #000000;text-align: left" dir="ltr">
Hi Christoph --
<div><br>
</div>
<div>Go ahead and improve the fix for Trunk. :-)</div>
<div><br>
</div>
<div>Best,</div>
<div>Marcel</div>
<div class="mb_sig"></div>
<blockquote class="history_container" type="cite" style="border-left-style:solid;border-width:1px; margin-top:20px; margin-left:0px;padding-left:10px;">
<p style="color: #AAAAAA; margin-top: 10px;">Am 09.01.2023 11:30:23 schrieb Thiede, Christoph <christoph.thiede@student.hpi.uni-potsdam.de>:</p>
<div style="font-family:Arial,Helvetica,sans-serif">
<div dir="ltr">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size: 12pt;color: #000000;font-family: Calibri,Helvetica,sans-serif">
<p>Nice catch! Note that there is also "Project current transcript" ... not sure about the pros and cons of "Smalltalk at: #Transcript".</p>
<p><br>
</p>
<p>Best,</p>
<p>Christoph</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif;color: #000000"><b>Von:</b> Squeak-dev <squeak-dev-bounces@lists.squeakfoundation.org> im Auftrag von commits@source.squeak.org <commits@source.squeak.org><br>
<b>Gesendet:</b> Montag, 9. Januar 2023 11:00:57<br>
<b>An:</b> squeak-dev@lists.squeakfoundation.org; packages@lists.squeakfoundation.org<br>
<b>Betreff:</b> [squeak-dev] The Trunk: Morphic-mt.2057.mcz</span>
<div> </div>
</div>
</div>
<span style="font-size: 10pt"><span style="font-size: 10pt">
<div class="PlainText">Marcel Taeumel uploaded a new version of Morphic to project The Trunk:<br>
<a href="http://source.squeak.org/trunk/Morphic-mt.2057.mcz">http://source.squeak.org/trunk/Morphic-mt.2057.mcz</a><br>
<br>
==================== Summary ====================<br>
<br>
Name: Morphic-mt.2057<br>
Author: mt<br>
Time: 9 January 2023, 11:00:54.890325 am<br>
UUID: f093a34d-1306-2f44-89ca-f90c796f94c4<br>
Ancestors: Morphic-ct.2056<br>
<br>
Fixes two issues with Trascript:<br>
1. "World Menu > Open... > transcript" should always count open transcripts<br>
2. Menu item "Tools > Transcript" must not bind Transcript global but use Smalltalk>>#at: lookup.<br>
<br>
The second bug occurred the moment we executed initialization code for new morphic projects to immediately render a preview thumbnail.<br>
<br>
Note that I am still not in favor of executing code of a new project in the scope of the current project due to process management, globals, and other stuff. Let's keep an eye on this.<br>
<br>
See<br>
<a href="http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-December/222795.html">http://lists.squeakfoundation.org/pipermail/squeak-dev/2022-December/222795.html</a><br>
<br>
I will backport this to Squeak 6.0.<br>
<br>
=============== Diff against Morphic-ct.2056 ===============<br>
<br>
Item was changed:<br>
----- Method: TheWorldMainDockingBar>>transcriptMenuItemOn: (in category 'submenu - tools') -----<br>
transcriptMenuItemOn: menu<br>
<br>
menu addItem: [ :item |<br>
item<br>
contents: 'Transcript' translated;<br>
help: 'Open the Transcript' translated;<br>
icon: (self colorIcon: Transcript windowColorToUse);<br>
+ target: [ (Smalltalk at: #Transcript) open ];<br>
+ selector: #value ].!<br>
- target: Transcript;<br>
- selector: #open ]!<br>
<br>
Item was changed:<br>
----- Method: TheWorldMenu>>openTranscript (in category 'commands') -----<br>
openTranscript<br>
<br>
+ Transcript open.!<br>
- Transcript openLabel: 'Transcript'!<br>
<br>
Item was changed:<br>
+ (PackageInfo named: 'Morphic') postscript: 'TheWorldMainDockingBar updateInstances. "Fix ''Tools > Transcript'' to make it late-bound."'!<br>
- (PackageInfo named: 'Morphic') postscript: 'TheWorldMainDockingBar updateInstances. "Updates menu for Help > Contributing to Squeak"'!<br>
<br>
<br>
</div>
</span></span></div>
</blockquote>
</div>
</body>
</html>