[FIX] FileDirectory-checkName-refactoring-jf ( [er] Needs tests )

[Julian Fitzell]

I agree I suppose.  The only reason I didn't is that I couldn't bring 
myself to write tests for valid characters in filenames without actually 
basing them off of some official document for each platform.  And I 
didn't have time to go looking for those documents for every platform. 
Figured it was better to post the refactoring anyway, even without tests.

Seems like we should be testing for correct behaviour rather than old 
behaviour, but if we're happy just testing that all the characters that 
were marked as illegal before are still marked as illegal after the 
refactoring, then I can write those tests...

Julian

cg at cdegroot.com wrote:
> I think this is a refactoring that needs to have some unit tests before
> we can harvest it.
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> <This post brought to you by BFAV2>