[BUG][FIX] TimeProfileBrowser ( [er][sm][et] looks OK, additional update provided )

[Robert Hirschfeld]

Hi David -- 

Here is yet another proposal, moving the handling of the 
most obvious error conditions into one clause. The first 
change set does that for the ending part of the method, 
the second one for the entire method. On the other hand, 
there are quite a few more places there that offer some 
room for improvement, so I'm not sure if we should just go 
with your proposal for now...

Best,
Robert

> -----Original Message-----
> From: lewis at mail.msen.com [mailto:lewis at mail.msen.com] 
> Sent: May 15, 2004 22:18
> To: squeak-harvest at lists.squeakfoundation.org; 
> robert.hirschfeld at gmx.net; lewis at mail.msen.com
> Subject: *** GMX Spamverdacht *** [BUG][FIX] 
> TimeProfileBrowser ( [er][sm][et] looks OK, additional update 
> provided )
> 
> 
> 
> I think that the "workaround" is OK. It is consistent with 
> other error handling appearing in the same method, and it 
> produces the intended result in the TimeProfileBrowser 
> display (i.e. no bottom pane display when lines in the GC 
> listing are selected).
> 
> I am attaching (hopefully, BFAV willing) an updated version 
> of Robert Hirschfeld's change set with a more concise error check.
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TimeProfileBrowserFix-rhi.cs.gz
Type: application/x-gzip
Size: 825 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-harvest/attachments/20040517/e755bbe2/TimeProfileBrowserFix-rhi.cs.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TimeProfileBrowserFix-rhi.2.cs.gz
Type: application/x-gzip
Size: 793 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/squeak-harvest/attachments/20040517/e755bbe2/TimeProfileBrowserFix-rhi.2.cs.bin