I forgot to said that the test is not that complicated. Just subclass DBXBaseTest and do something like:<br><br>testCorrectQuotesArroundQuery<br> | conn select |<br> conn := self doConnectAndOpen.<br> select := 'SELECT * FROM signature where XXX...'.<br>
self shouldnt: [conn execute: select. ] raise: DBXError.<br> conn disconnect.<br><br><br><div class="gmail_quote">On Sat, Oct 10, 2009 at 6:45 PM, Mariano Martinez Peck <span dir="ltr"><<a href="mailto:marianopeck@gmail.com" target="_blank">marianopeck@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Herbert: I attach you a png. Is that what you need ?<br><br>I cannot past it here because gmail put me the same quotes :(<br>
<br>best,<br><font color="#888888"><br>mariano</font><div><div></div><div><br><br><div class="gmail_quote">On Sat, Oct 10, 2009 at 5:31 PM, Mariano Martinez Peck <span dir="ltr"><<a href="mailto:marianopeck@gmail.com" target="_blank">marianopeck@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><br><div class="gmail_quote">2009/10/10 Herbert König <span dir="ltr"><<a href="mailto:herbertkoenig@gmx.net" target="_blank">herbertkoenig@gmx.net</a>></span><div>
<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Mariano,<br>
<br>
I think I need some help in this matter.<br></blockquote></div><div><br>Ok, let's try to fix it.<br> </div><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
HK> As to keep it manageable I'll factor the String<br>
HK> 'INSERT INTO signature(code, name, observations, id_student)<br>
HK> VALUES (11, ''Something'', ''Nothing'', 2)'<br>
HK> into a method in DBXBackendFacility and overwrite it in<br>
HK> DBXMySQL4Facility.<br>
<br>
MMP> I would like not to tauch DBXBackendFacility or other<br>
MMP> things of the core. Is it possible it to be only in<br>
MMP> MMP> DBXMySQL4Facility ?<br>
<br></blockquote></div><div><br><br>
I think I am not understanding. What I need an example. What I suggest
you is you send me your changeset so that I can see it and try to run
it in different backends.<br> </div><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I have to touch all these messages in the png.<br>
</blockquote><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
The options I see:<br>
- Changing all these strings to use double quotes around "Something"<br>
and "Nothing" and hope that in SQL '' and "" are interchangeable for<br>
all platforms.<br></blockquote></div><div><br>That's why I didn't want to touch everything. I don't want to break others backends. <br> </div><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
- Changing these Strings only after a check for the Class of the<br>
faciility<br>
- Instead of using String literals return the Strings by a method.<br>
This method could reside in DBXBaseTest and do something like:<br>
facility class = DBXMySQL4Facility ifTrue: [....] ifFalse: [...]<br>
Or this method resides in DBXBackendFacility and uses polymorhism to<br>
return the appropriate string.<br>
<br></blockquote></div><div><br>In those options I like the last one, the one of polymorhism. However, as I told you, send me the changeset so that I can test it here. <br><br>Even better, what would be fantastic is you do a new test that just tests that. So, you send me that test and I just run it for all backends on all OS.<br>
What do you think about this? It is easy and helpful.<br><br> </div><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Happy for any other suggestion you make and I will follow your<br>
suggestion as it is my goal to have MySQL4 and tests included into<br>
SqueakDBX.<br>
<br></blockquote></div><div><br>Yeah. Me too. The goal is to have all the tests running in all backends and OS. <br> </div><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Actually I don't understand (meaning I want to be educated about) your<br>
objection. In my view it will be a simple getter and IMO it's a<br>
natural function for DBXBackendFacility to provide different SQL<br>
strings for different backends.<br>
<br></blockquote></div><div><br>Come on!!! I am still an Smalltalk newbie :) Don't be afraid, just ask, advice or whatever.<br><br>I think that's is a nice solution. But I would like to be sure that you changes don't work with others backends. Because perhaps they work and we are doing all of this without sense.<br>
</div><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
But then I'm no IT person but an electronic engineer so maybe it's<br>
just a lack of understanding on my side.<br>
<div><div></div><div><br></div></div></blockquote></div><div><br>no :)<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div>
<div>
<div>
Cheers,<br>
<br>
Herbert mailto:<a href="mailto:herbertkoenig@gmx.net" target="_blank">herbertkoenig@gmx.net</a></div></div><br></div><div>_______________________________________________<br>
SqueakDBX mailing list<br>
<a href="mailto:SqueakDBX@lists.squeakfoundation.org" target="_blank">SqueakDBX@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx</a><br>
<br></div></blockquote></div><br>
</blockquote></div><br>
</div></div></blockquote></div><br>