<br><br><div class="gmail_quote">On Tue, Oct 20, 2009 at 1:17 AM, John Toohey <span dir="ltr"><<a href="mailto:jt@parspro.com">jt@parspro.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Yep, I've been looking at this also. I guess adding it to the GlorpPharoPort package is a solution. I think asNumber should fail in this case, but having a method in GlorpPharoPort package return 0 in this case seems to be the only solution. Maybe someone on the Pharo list will come up with something better. <div>
<div></div><div class="h5"><div>
<br></div></div></div></blockquote><div><br>Ok...the change in Pharo with String>>asNumber was rollbacked in 10492 and Glorp has all green tests with it :)<br><br>Let's wait for 1.1 to change it. <br><br>Best<br>
<br>Mariano<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div class="h5"><div></div><div><br><br><div class="gmail_quote">
On Mon, Oct 19, 2009 at 23:31, Mariano Martinez Peck <span dir="ltr"><<a href="mailto:marianopeck@gmail.com" target="_blank">marianopeck@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br><br><div class="gmail_quote"><div>On Mon, Oct 19, 2009 at 11:14 PM, John Toohey <span dir="ltr"><<a href="mailto:jt@parspro.com" target="_blank">jt@parspro.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Thanks Mariano , have it installed now, but I think I'll wait for a resolution to the asInteger issue. I have the same 4 failing tests.<div><div></div><div><br><br></div></div></blockquote></div><div><br>The problem is in <br>
<br> readTimeFromStream: aStream for: aType<br> readTimestampFromStream: aStream for: aType<br><br>Where it does:<br><br>timeZoneOffset := aStream upToEnd asNumber.<br><br>many times aStream upToEnd is '' and '' asNumber raise an error in Pharo. The error is 'Reading a number failed'.<br>
<br>Nicolas suggest to use Number readFrom: self ifFail: [^0]<br><br>but this message is only implemented in Pharo, not squeak :(<br><br>So, do you have an idea of how to do this so that it runs in Pharo AND squeak ?<br>
<br>
The only solution I see is to implement asNumberOrZero as a Glorp extension, but I don't know if this is the best. At least it works.<br><br>Any idea?<br><br>best<br><font color="#888888"><br>mariano<br><br> </font></div>
<div><div></div><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div><div class="gmail_quote">On Mon, Oct 19, 2009 at 21:09, Mariano Martinez Peck <span dir="ltr"><<a href="mailto:marianopeck@gmail.com" target="_blank">marianopeck@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br><br><div class="gmail_quote"><div><div></div><div>On Mon, Oct 19, 2009 at 6:46 PM, John Toohey <span dir="ltr"><<a href="mailto:jt@parspro.com" target="_blank">jt@parspro.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>Installer ss project: 'Glorp'; install: 'GlorpPharoLoader'</div><div>GlorpPharoLoader loadGlorpWithNativePostgreSQLDriver</div><div><br></div><div>This fails with a syntax error on Pharo 10477. No really sure what it is doing but I think the data that it is reading from the site is in error.</div>
<div><br></div></blockquote></div></div><div><br>Thanks john. It was my fault, as I changed a URL. I commited the fix in:<br><br>Name: GlorpPharoLoader-MarianoMartinezPeck.6<br>Author: MarianoMartinezPeck<br>Time: 19 October 2009, 10:08:21 pm<br>
UUID: 45effe51-e9d4-4fc1-a20f-f25c67c5dc1b<br>Ancestors: GlorpPharoLoader-MarianoMartinezPeck.5<br><br>The undersore.cs changed the URL in assembla<br><br>However....I am getting 4 failing test which is due that now in pharo '' asInteger returns an error instead of zero (as it was in older images). I asked in mailing list about this.<br>
<br>Best<br><br>Mariano<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div></div><br>-- <br><font color="#888888">-JT<br><br><br>
</font><br>_______________________________________________<br>
SqueakDBX mailing list<br>
<a href="mailto:SqueakDBX@lists.squeakfoundation.org" target="_blank">SqueakDBX@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx</a><br>
<br></blockquote></div><br>
<br>_______________________________________________<br>
SqueakDBX mailing list<br>
<a href="mailto:SqueakDBX@lists.squeakfoundation.org" target="_blank">SqueakDBX@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx</a><br>
<br></blockquote></div><br><br clear="all"><br></div></div>-- <br><font color="#888888">-JT<br><br><br>
</font><br>_______________________________________________<br>
SqueakDBX mailing list<br>
<a href="mailto:SqueakDBX@lists.squeakfoundation.org" target="_blank">SqueakDBX@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx</a><br>
<br></blockquote></div></div></div><br>
<br>_______________________________________________<br>
SqueakDBX mailing list<br>
<a href="mailto:SqueakDBX@lists.squeakfoundation.org" target="_blank">SqueakDBX@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>-JT<br><br><br>
</div>
</div></div><br>_______________________________________________<br>
SqueakDBX mailing list<br>
<a href="mailto:SqueakDBX@lists.squeakfoundation.org">SqueakDBX@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx</a><br>
<br></blockquote></div><br>