Ok....I filein your tests, and could crash when using MSSQL. After that, I applied the patch to mssql_basic.c and all were green :)<br><br>After that, I check the rest of the backends. I had to disable these tests for Sqlite3 as for Sqlite3 you don't need those parameters, so, you shouldn't raise an exception. I also changed testConnectBadHost to catch DBXError instead of DBXFatalError because in Oracle that error is managed as Recoverable.<br>
<br>Thanks for all of your help stefan. <br><br>See my commit:<br><br><br>Name: OpenDBX-Core-MarianoMartinezPeck.249<br>Author: MarianoMartinezPeck<br>Time: 27 November 2009, 4:44:37 pm<br>UUID: ddb7a31b-4422-4438-9fab-fe42bfa22f71<br>
Ancestors: OpenDBX-Core-aaa.248<br><br>Thanks to Stefan Kapusniak we have new tests that tests what happens if we set bad data to settings like host, username and password. <br><br>In addition, with MSSQL, when this was done, SqueakDBX didn't receive any error from OpenDBX and when a query was send, the image crash. So, to get green tests in MSSQL you should apply the patch. We will talk to Norbert so that to put this fix in the next release. <br>
<br><br><br><div class="gmail_quote">On Fri, Nov 27, 2009 at 7:52 AM, Stefan Kapusniak <span dir="ltr"><<a href="mailto:mlist@yclept.clara.co.uk">mlist@yclept.clara.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">On Thu, 26 Nov 2009 22:10:50 -0300, Mariano Martinez Peck wrote:<br>
<br>
> One question: if you put some data wrong, as you said. For example,<br>
> non existent user or something similar, the connect and open<br>
> message does not return error ??? I mean....if you are able to send<br>
> a query is because those messages where successful.<br>
> Am I correct?<br>
<br>
</div>Yes, I don't get any sort of error at least from the Smalltalk code. The<br>
OpenDBX backend code *looks* like it's raising an error however.<br>
<br>
I'm not sure whether the actual problem is OpenDBX not raising the<br>
error properly or SqueakDBX not detecting it correctly. Getting OpenDBX<br>
to set the errtype in it's connection structure does make the Smalltalk<br>
side see the error.<br>
<div class="im"><br>
> If this is the case, I will ask Norbert, because we should receive<br>
> an error in that case.<br>
<br>
</div>...see my other mail with a patch to OpendDBX that sets the errtype :)<br>
<div><div></div><div class="h5"><br>
-- Stefan<br>
_______________________________________________<br>
SqueakDBX mailing list<br>
<a href="mailto:SqueakDBX@lists.squeakfoundation.org">SqueakDBX@lists.squeakfoundation.org</a><br>
<a href="http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx" target="_blank">http://lists.squeakfoundation.org/mailman/listinfo/squeakdbx</a><br>
</div></div></blockquote></div><br>