<br><br><div class="gmail_quote">On Sat, Sep 11, 2010 at 7:07 PM, Panu Suominen <span dir="ltr"><<a href="mailto:panu.j.m.suominen@gmail.com">panu.j.m.suominen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
2010/9/11 Mariano Martinez Peck <<a href="mailto:marianopeck@gmail.com">marianopeck@gmail.com</a>>:<br>
<div class="im">> Few more things:<br>
><br>
> 1) PSAutomaticEncoding >> encoderFor: anObject<br>
</div><div class="im">> I think it would be better to be:<br>
> PSAutomaticEncoding >> encoderFor: aConnection<br>
</div><div class="im">> Since object DNU queryEncodying, but DBXConnection.<br>
<br>
</div>You are right. I thought that same kind of encoding strategy scheme<br>
could be used to some other things as well.<br>
But anObject is too general name.<br></blockquote><div><br>Yes, I imagined it was because of that....but it cannot be too general, since it has to understand queryEncodying....<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im"><br>
> 2) testUTF8IsDetected fails because there is no implementor of<br>
> runScenario<br>
</div>It needs mocketry to run. I though that I would add some kind of<br>
notice about this<br>
requirement when class is initialized or something, but I runned out<br>
of time to find<br>
out how to do this proprely.<br>
<br>
Other option is that I take extra effort to write the test without<br>
mocketry. Is that<br>
better option?<br></blockquote><div><br>Yes, please. If that's the only place where it is used then yes. Because depending on other packages is complicated. You never know if there is someone who maintains it. And I want to to always run fine in Pharo. Pharo changes a lot. So yes....since it seems mockery is only used there, I would try to avoid the dependecy.<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im"><br>
> 3) TO integrate it, I was thnking I can put the classes of<br>
> 'EncodingStrategy' into a new 'OpenDBX-Core-Encoding'<br>
> And the tests in 'OpenDBX-Core-Tests-Encoding'<br>
> In addition, I have to rename PSAclassName to DBXAclassName. Do you agree<br>
> with this?<br>
<br>
</div>Sounds good. I think my changes are so small that licensing them<br>
sounds funny but<br>
because there have been some licensing issues it might be better that<br>
I clearly state that my changes are done under MIT license.<br></blockquote><div><br>Excellent, because I was just going to ask you that :)<br>Thanks for doing it mit. <br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<br>
If I remember correctly Glorp uses LGPL? If so then the change to Login<br>
class has to be LGPL too.<br>
<br></blockquote><div><br>yes...I guess. <br><br>Thanks Panu.<br></div></div>