[Squeakfoundation]Ad-hoc final harvesting for 3.4

Daniel Vainsencher squeakfoundation@lists.squeakfoundation.org
Mon, 09 Dec 2002 16:49:52 +0300

Commenting about many but not all of the changes noted. BTW, do we want
to CC the authors, or do we assume they're reading the list?

Doug Way <dway@riskmetrics.com> wrote:
> 1. Ones that I think could probably go in 3.4:
> ----------------------------------------------
> [ENH] Add lines to hierarchy views (5 December 2002) * sps2000@mail.com 
> (5 December 2002)
> http://swiki.gsug.org:8080/sqfixes/2877.html
> [ENH] LinesInHierWIcon-nk (5 December 2002) * Ned Konz (5 December 2002)
> http://swiki.gsug.org:8080/sqfixes/2879.html
> [ENH] HierListsWithIcon-nk (4 December 2002) * Ned Konz (4 December 2002)
> http://swiki.gsug.org:8080/sqfixes/2870.html
> - A few of us agreed that we'd like to see these go in.  Perhaps the 
> only question is whether they're reasonably safe for 3.4beta.  I think 
> that they probably are, but more opinions are welcome.  (Although I do 
> notice that scrolling large lists in the object explorer (e.g. the 
> Smalltalk dictionary) is a bit slower now with the lines drawn, as Ned 
> mentioned.  And, in certain cases, the dreaded "gribbleys" show up, 
> although they're hard to notice because the lines are faint to begin 
> with.  These problems aren't too serious and may be easy to fix.  Or 
> maybe we could just add the Icon stuff for now.  Or just put it all off 
> until 3.5alpha. :-) )
Doug, can you give Steve a recipe to reproduce gribbleys, and see if
this can be fixed? I didn't notice anything...

> [FIX] Translation to iso-8859-1 encoding in Scamper (16 November 2002) * 
> Boris Gaertner (16 November 2002)
> http://swiki.gsug.org:8080/sqfixes/2770.html
> - It sounds like this one has been tested pretty well.  With this fix, 
> if I look at 
> http://map2.squeakfoundation.org/sm/package/4f0b9db6-8add-43aa-8d6b-53e6a0ea8442 
> in Scamper, Göran's name now shows up correctly.
I think in scope it is a bit non-essential (maintain Scamper as a
package, anyone?), but it works and the code looks simple too, so lets
add it.

> [FIX] UUID-Fix-CdG (19 November 2002) * cg@cdegroot.com (19 November 
> 2002)
> http://swiki.gsug.org:8080/sqfixes/2786.html
> - Discussed in Goran's post.  It sounds like there is some agreement 
> that we should go with this simple fix for now, and fix Random sometime 
> in the future, since that is much more involved.
Ok, has this been tested by someone other than the poster for all the
relevant situations (unix/notunix with sound input/neither of the
above)? Other than that, I'd take it, as a temporary solution. A real
UUID generator accessing the MAC of an interface and so forth would be

> 2. Ones that I think could probably wait until 3.5alpha for 
> consideration, or have already been fixed:
> --------------------------------------------------------------------------
> [ENH] Comma concatenation for Object (6 December 2002) * Brent Pinkney 
> (6 December 2002)
> http://swiki.gsug.org:8080/sqfixes/2883.html
> - Seems like a significant (and possibly controversial) change for a 
> beta release.
I think it would hide bugs quite often, and doesn't solve a serious
problem, given {} notation. I don't think it should be included.
> [GOODIE] Matrix-raok (28 November 2002) * ok@cs.otago.ac.nz (28 November 
> 2002)
> http://swiki.gsug.org:8080/sqfixes/2838.html
How about removing array2d from the image? seems to me this could be an
SM package. There is one reference to array2d in the image, it is from a
method with no senders.
> [ENH] ANSI compatibility (24 November 2002) * Alain Fischer (24 November 
> 2002)
> http://swiki.gsug.org:8080/sqfixes/2820.html
> - Should probably wait until 3.5alpha, but it would be worth considering 
> then (not necessarily all of it).
I agree. Also, it's a big change set with many different things -
- Improvements to TestRunner (Should be considered together with the
TestRunnerEnhancements by Ned).
- New date related classes, including DataAndTime (which we might want
to start using generally in the image), and including a few utility
classes. This might require a little upheaval, and I would discuss them
for 3.5.
- Some arithmetic classes, including a new kind of number. Probably
could go into 3.4, but I'd value the opinion of other people that have
an interest in numbers and the standard.
- A set of new exceptions which should be used wherever specific kinds
of errors occur. The image might have to be prepared to catch them.

> 3. Ones that I leave the rest of you to decide:
> -----------------------------------------------
> [FIX][3.4] Enhanced-IRC with dynamic open menu (4 December 2002) * Brent 
> Vukmer (4 December 2002)
> http://swiki.gsug.org:8080/sqfixes/2872.html
This is not a fix to the image, it is to a package. Not our call.. but
I'd definitely like to see it applied.
> [FIX] Celeste in MVC (4 December 2002) * Bruce ONeel (4 December 2002)
> http://swiki.gsug.org:8080/sqfixes/2864.html
I'm against. Celeste should work in MVC, but this implementation adds
too much complexity to Celeste. It would be better to either fix some of
the small missing things in MVC, or to separate the compatibility stuff
so that Celeste doesn't know what interface it's running. More generally
speaking, over all it adds complexity, just so a package can run better.
This is the sort of place where we should remove the package, not fatten
the image. (yes, I'll work on making Celeste removable so we can do

> [ENH] Keyboad navigation for SimpleHierarchicalListMorph (28 November 
> 2002) * Thierry Reignier (28 November 2002)
> http://swiki.gsug.org:8080/sqfixes/2841.html
> - Seems kind of useful.
Ah, I hadn't seen this, I've wanted it it for quite a while. I think we
definitely need it, except that in my brief testing, I couldn't get
left/right/cr to do anything (in other words, expand/collapse doesn't
> [Fix][Enh]ShrinkingSelection(was: Re: Behavior of Shift+arrow) (24 
> November 2002) * Torge.Husfeldt (24 November 2002)
> http://swiki.gsug.org:8080/sqfixes/2825.html
> - This is very nice... hmm.  I tested this a bit, and it works.  I'd 
> even prefer to see this preference turned on by default.  The other 
> added preference (wordStyleCursorMovement) is a good idea, too (though 
> it could be off by default).  Still, this involves a fair amount of 
> changes, and perhaps should wait until 3.5alpha for that reason.
I'd want to get this into 3.4 if someone else familiar with the
selection code to vet it. Otherwise, I'd propose to put it in 3.5a, with
any new preferences turned on to get them exercised (generally speaking,
we can tweak preferences to be "mainstream" in gamma releases, but
should use alpha time to get feedback on the weirder variations).

> [ENH] LargeInteger hash (24 November 2002) * Andres Valloud (24 November 
> 2002)
> http://swiki.gsug.org:8080/sqfixes/2822.html
In general looks like a good idea. Issues -
* What sort of testing has this had? Andres? anyone else?
* There are question marks in Interpreter>>obsoleteNamedPrimitiveTable.
It's not clear to me what decisions are still not clear, and whether
this causes an incompatibilty with other VMs, because of the name change
to the existing primitive.

> [GOODIE] WatchWindow-nk (24 November 2002) * Ned Konz (24 November 2002)
> http://swiki.gsug.org:8080/sqfixes/2821.html
> [GOODIE] MorphInspector-nk (24 November 2002) * Ned Konz (24 November 
> 2002)
> http://swiki.gsug.org:8080/sqfixes/2819.html
> [ENH] BrowseModelClass-nk (24 November 2002) * Ned Konz (24 November 
> 2002)
> http://swiki.gsug.org:8080/sqfixes/2817.html
> - These are some longstanding enhancements posted by Ned, probably in 
> response to my "call for submissions".  None of them look like 
> must-haves to me, although I kind of like the WatchWindow... that might 
> be worth adding to the base release.  It adds "watch it" to the do-
> it/print-it/inspect-it menu... is it worth its weight?
A worthy package today, might go into configurations tommorrow.
> [FIX] MessageSetDragFix-nk (24 November 2002) * Ned Konz (24 November 
> 2002)
> http://swiki.gsug.org:8080/sqfixes/2818.html
> [ENH] image previewer in world menu --> open... (23 November 2002) * 
> Brent Vukmer (23 November 2002)
> http://swiki.gsug.org:8080/sqfixes/2811.html
Does the job. Many changes for FileList2, can anyone comment on those?

It seems to conflict with the hierarchy navigation changes discussed -
when I first load the keyboard navigation, then this changeset, opening
the previewer caused an infinite regression, and image death, with this
stack dump -

1087678728 Object>canDiscardEdits
1087678636 [] in Object>canDiscardEdits
1087678544 SequenceableCollection>do:without:
1087678452 Object>canDiscardEdits
1087678360 Model>canDiscardEdits
1087678268 StringHolder>okToChange
1087678176 FileList2>directory:
1087678084 FileList2>setSelectedDirectoryTo:
1087677992 SimpleHierarchicalListMorph>setSelectedMorph:
1087667708 [] in IndentingListItemMorph>openPath:
1087667608 IndentingListItemMorph>withSiblingsDo:
1087667516 IndentingListItemMorph>openPath:
1087667104 [] in IndentingListItemMorph>openPath:
1087667000 IndentingListItemMorph>withSiblingsDo:
1087666908 IndentingListItemMorph>openPath:
1087656424 [] in IndentingListItemMorph>openPath:
1087656316 IndentingListItemMorph>withSiblingsDo:
1087656224 IndentingListItemMorph>openPath:
1087655584 [] in IndentingListItemMorph>openPath:
1087655380 IndentingListItemMorph>withSiblingsDo:
1087655288 IndentingListItemMorph>openPath:
1087655172 SimpleHierarchicalListMorph>update:
1087655472 [] in Object>changed:
1087655068 DependentsArray>do:
1087654976 Object>changed:
1087654844 FileList2>postOpen
1087488192 FileList2 class>morphicViewImageViewerWithPreview
1087488008 FileList2 class>openMorphicViewWithPreviewInWorld

> [FIX] smtpLogin-fix (22 November 2002) * m rueger (22 November 2002)
> http://swiki.gsug.org:8080/sqfixes/2808.html
This is a fix to mirs network rewrite. So it's not currently applicable.
Speaking of which, I would like to know how that is doing. I've been
testing the SMTP stuff since it was released, and have no complaints to
it, so maybe it's time to start integrating it. I don't want to wait
until it's all done.

> [ENH] system category cleanup in 3.4a (20 November 2002) * Anthony 
> Hannan (20 November 2002)
> http://swiki.gsug.org:8080/sqfixes/2788.html
> - Preamble claims this was requested by Scott Wallace. :-)
already in as 5112.

> [BUG][FIX] BitEditor>>setColor: (18 November 2002) * Brian T Rice (18 
> November 2002)
> http://swiki.gsug.org:8080/sqfixes/2781.html
In as 5116.

Daniel Vainsencher