[Squeakfoundation]defineClass fix!

goran.hultgren@bluefish.se squeakfoundation@lists.squeakfoundation.org
Mon, 16 Dec 2002 13:28:15 +0100


"Andreas Raab" <andreas.raab@gmx.de> wrote:
> > The bug was introduced by Torge's 5137 fix.
> 
> What was the fix?! If I revert that change then everything seems to be
> all right. It doesn't have any effect I can see...

It appeared to be a check so that one can't enter methods when the
method category "all" is selected. But I never verified that Torge's
check worked... I just assumed it did.

Aha, ok - the idea is that it gives you a proper "inform" instad of
"Nothing more expected ->" if you start entering a method without first
selecting a method category. If I understood it correctly.

On the other hand it does feel really ugly to test for certain keywords
in the message (that is also why the fix turned sour) - my fix is
equally ugly in that respect. Actually - I vote for dropping this
altogether, it's simply bad code - mine included, but I claim innocense
since I got dragged into it by Torge! :-).

regards, Göran