[Squeakfoundation]Harvester status for Marcus Denker
goran.krampe at bluefish.se
goran.krampe at bluefish.se
Sun Jun 8 23:40:28 CEST 2003
Hi Daniel, Marcus and all!
Daniel Vainsencher <danielv at netvision.net.il> wrote:
> I think Marcus has done more useful harvesting work in the last couple
> of days than most of us in N weeks.
Yup. :-)
> I'd say that Marcus can and should be trusted to approve stuff, except
Agree.
> for one thing - I haven't seen him post critical comments on any of the
> code he's reviewed, and for anyone that's going to be able to get stuff
> into the image where we all have to live with it, I want to know that he
> can be point out where code is lacking.
I am sure Marcus can do that too! :-) Personally I have found that the
code I have reviewed from others generally is good - but class comments
and method comments tend to lack IMHO.
I really want the quality of comments to be higher in the official
classes. I would personally never let classes in without class comments.
> Except for the selection aspect, this is also important because posting
> these public comments is the way knowledge is transmitted about good/bad
> practice, and not just to the author of the specific code.
>
> What does everybody think?
>
> Daniel
I definitely think Marcus should be a Harvester - if he likes to be one.
:-) Marcus is surely a more competent Squeaker than I am so... ;-)
regards, Göran
More information about the Squeakfoundation
mailing list