[UI] ToolBuilder

[Igor Stasenko]

On 11/09/2007, Gary Chambers <gazzaguru2 at btinternet.com> wrote:
> Good job that PluggableTextMorph delegates much of its work to its TextMorph (and then Paragraph) otherwise would indeed be massive!

Looking a strange for me.. Text morph delegating to text morph?
I don't know what intent was to make it, but maybe subclassing instead
of delegation would be better?

>
> > -----Original Message-----
> > From: ui-bounces at lists.squeakfoundation.org
> > [mailto:ui-bounces at lists.squeakfoundation.org]On Behalf Of Igor Stasenko
> > Sent: 10 September 2007 9:21 PM
> > To: Squeak's User Interface
> > Subject: Re: [UI] ToolBuilder
> >
> >
> > On 10/09/2007, Jason Johnson <jason.johnson.081 at gmail.com> wrote:
> > > That morph seems to be doing way too much.  It's at least (1) a view,
> > > (2) an aspect and (3) a dialog (i.e. save changes or drop them).
> > >
> > Concerning PluggableTextMorph class i agree. It contains too much
> > functionality in single entity.
> >
> > PluggableTextMorph methodDictionary size 117
> > ^^ indicates that there is something utterly wrong with design,
> > because of too many added/overridden methods. Its very hard to study
> > as a whole because of its size.
> >
> > Personally, i'm always suspicious and dislike classes which have more
> > than 20-30 methods (per subclass/protocol) i start thinking that its
> > easier to make own class, than spend time studying so huge interfaces
> > just to find out that it needs an additional coding to fit your
> > purposes. To be precise, i barely see any task/model which requires
> > more than 20-30 methods to denote its purpose. If my model does not
> > fits in small set i'm always start thinking about dividing it to
> > number of smaller entities and deal with them, instead of a one huge
> > and complex thing.
> >
> > --
> > Best regards,
> > Igor Stasenko AKA sig.
> > _______________________________________________
> > UI mailing list
> > UI at lists.squeakfoundation.org
> > http://lists.squeakfoundation.org/mailman/listinfo/ui
> >
>
> _______________________________________________
> UI mailing list
> UI at lists.squeakfoundation.org
> http://lists.squeakfoundation.org/mailman/listinfo/ui
>


-- 
Best regards,
Igor Stasenko AKA sig.