Merge big cursor support (was: [Vm-dev] coordination between the olpc and official svn branches)

David T. Lewis lewis at mail.msen.com
Sun Nov 16 21:01:25 UTC 2008


On Sun, Nov 16, 2008 at 08:15:01PM +0100, Bert Freudenberg wrote:
> On 16.11.2008, at 20:00, David T. Lewis wrote:
> >On Tue, Nov 11, 2008 at 03:06:24PM +0100, Bert Freudenberg wrote:
> >>Of the Interpreter changes, I think only #primitiveBeCursor is still
> >>relevant (adds ARGB support), the rest of the differences should come
> >>from the sqUInt cleanups.
> >
> >That looks right, so I'll focus on #primitiveBeCursor first.
> >
> >I am attaching an update to your bigCursor-bf change set with two
> >modifications that I think should be made to merge back into newer  
> >VMMaker
> >versions:
> >
> >1) Changed #fetchWord:ofObject: to #fetchLong32:ofObject: in two  
> >places.
> >The #fetchWord:ofObject: method is deprecated in recent VMMaker  
> >versions.
> >
> >2) Restored check for 64 bit object word size. This makes the  
> >primitive
> >into a no-op for 64 bit images, and is flagged for a fix when bitmap
> >conversion is implemented. I presume that this has not yet been done,
> >so I think the check should remain for now.
> >
> >If you agree with these changes, I will apply them to the *-dtl thread
> >of updates in SqueakSource VMMaker. The remaining to-do item will be  
> >to
> >implement ioSetCursorARGB() in the win32 and RiscOS platform sources.
> >These can presumably be no-ops for starters.
> >
> >I also opened a Mantis issue to track this and provide a record of  
> >what
> >we're doing (http://bugs.squeak.org/view.php?id=7224).
> >
> >Thanks,
> >Dave
> >
> ><bigCursor-bf-dtl.2.cs>
> 
> Looks good :)

Thanks, the changes are included in VMMaker-dtl.108 and VMMaker-dtl.107 (same
as 108 but with SlangBrowser and MemoryAccess included) on SqueakSource VMMaker.

Dave



More information about the Vm-dev mailing list