[Vm-dev] Resource Directory support for Windows (VM 4.2.1Beta Window version ?)

Bert Freudenberg bert at freudenbergs.de
Tue Aug 25 18:16:06 UTC 2009


On 25.08.2009, at 19:36, Yoshiki Ohshima wrote:

> At Tue, 25 Aug 2009 10:09:13 -0700,
> John M McIntosh wrote:
>>
>> Yoshiki, I had the same code and was scratching my head over it. I  
>> had
>> forgotten that I had originally cloned the Windows logic.
>> However when I was comparing to the unix code I decided to dump that
>> code base and replace it with Ian's rewrite & Bert's modifications.
>>
>> You might consider reviewing the unix code for isAccessiblePathName &
>> etc so all VM have the same behaviour.
>
>  Thank you, John.  Attached is a revised patch, which could be good
> to get in.
>
>  As I wrote, the logic is almost the same as the Unix version; but
> there is no realpath(), and there is no strong urge to support
> symlinks.  So it only tests if the remaining part contains "\.." (not
> just "..", which could be a part of legitimate file name).
>
> -- Yoshiki
> <sqWin32Security.c.diff>


In your patch, resourceDirectory defaults to "C:\My Squeak". I think  
the image directory is a better default? That's what I did for unix  
anyway.

- Bert -




More information about the Vm-dev mailing list