[Vm-dev] Float math in VMMaker-dtl.123

David T. Lewis lewis at mail.msen.com
Wed Jul 1 16:56:43 UTC 2009


On Wed, Jul 01, 2009 at 08:32:18AM -0700, Andreas Raab wrote:
> 
> Ouch. Yeah, I'd say that's right...

This is from http://bugs.squeak.org/view.php?id=7260. I reopened the
issue on Mantis.

I'll apply the fix to VMMaker as soon as I can (but feel free to do the
update if I don't get to it first; Bert you have developer access as well
as Andreas of course). 

Dave

> 
> Bert Freudenberg wrote:
> >
> >I just noticed that
> >
> >bytecodePrimGreaterOrEqual
> >    ...
> >    aBool := self primitiveFloatLess: rcvr thanArg: arg.
> >    successFlag ifTrue: [^self booleanCheat: aBool not].
> >
> >got changed to
> >
> >bytecodePrimGreaterOrEqual
> >    ...
> >    aBool := self primitiveFloatGreaterOrEqual: rcvr toArg: arg.
> >    successFlag ifTrue: [^self booleanCheat: aBool not].
> >
> >but shouldn't that be
> >
> >bytecodePrimGreaterOrEqual
> >    ...
> >    aBool := self primitiveFloatGreaterOrEqual: rcvr toArg: arg.
> >    successFlag ifTrue: [^self booleanCheat: aBool].
> >
> >and similarly for bytecodePrimLessOrEqual?
> >
> >- Bert -
> >
> >


More information about the Vm-dev mailing list