[Vm-dev] Float math in VMMaker-dtl.123

Nicolas Cellier nicolas.cellier.aka.nice at gmail.com
Wed Jul 1 17:02:59 UTC 2009


2009/7/1 David T. Lewis <lewis at mail.msen.com>:
>
> On Wed, Jul 01, 2009 at 08:32:18AM -0700, Andreas Raab wrote:
>>
>> Ouch. Yeah, I'd say that's right...
>
> This is from http://bugs.squeak.org/view.php?id=7260. I reopened the
> issue on Mantis.
>
> I'll apply the fix to VMMaker as soon as I can (but feel free to do the
> update if I don't get to it first; Bert you have developer access as well
> as Andreas of course).
>
> Dave
>

Ouch again, my fault.
How can the tests pass... Hmm not enough test?

Nicolas

>>
>> Bert Freudenberg wrote:
>> >
>> >I just noticed that
>> >
>> >bytecodePrimGreaterOrEqual
>> >    ...
>> >    aBool := self primitiveFloatLess: rcvr thanArg: arg.
>> >    successFlag ifTrue: [^self booleanCheat: aBool not].
>> >
>> >got changed to
>> >
>> >bytecodePrimGreaterOrEqual
>> >    ...
>> >    aBool := self primitiveFloatGreaterOrEqual: rcvr toArg: arg.
>> >    successFlag ifTrue: [^self booleanCheat: aBool not].
>> >
>> >but shouldn't that be
>> >
>> >bytecodePrimGreaterOrEqual
>> >    ...
>> >    aBool := self primitiveFloatGreaterOrEqual: rcvr toArg: arg.
>> >    successFlag ifTrue: [^self booleanCheat: aBool].
>> >
>> >and similarly for bytecodePrimLessOrEqual?
>> >
>> >- Bert -
>> >
>> >
>


More information about the Vm-dev mailing list