[Vm-dev] Float math in VMMaker-dtl.123

Eliot Miranda eliot.miranda at gmail.com
Wed Jul 1 18:02:33 UTC 2009


On Wed, Jul 1, 2009 at 10:02 AM, Nicolas Cellier <
nicolas.cellier.aka.nice at gmail.com> wrote:

>
> 2009/7/1 David T. Lewis <lewis at mail.msen.com>:
> >
> > On Wed, Jul 01, 2009 at 08:32:18AM -0700, Andreas Raab wrote:
> >>
> >> Ouch. Yeah, I'd say that's right...
> >
> > This is from http://bugs.squeak.org/view.php?id=7260. I reopened the
> > issue on Mantis.
> >
> > I'll apply the fix to VMMaker as soon as I can (but feel free to do the
> > update if I don't get to it first; Bert you have developer access as well
> > as Andreas of course).
> >
> > Dave
> >
>
> Ouch again, my fault.
> How can the tests pass... Hmm not enough test?


There are no > < >= or <= tests in the FloatTest class.   I just read the
draft IEEE 754 spec and didn't find it easy going so I'd much rather you
wrote the tests than I :)  I'm very happy to get them to pass.


>
> Nicolas
>
> >>
> >> Bert Freudenberg wrote:
> >> >
> >> >I just noticed that
> >> >
> >> >bytecodePrimGreaterOrEqual
> >> >    ...
> >> >    aBool := self primitiveFloatLess: rcvr thanArg: arg.
> >> >    successFlag ifTrue: [^self booleanCheat: aBool not].
> >> >
> >> >got changed to
> >> >
> >> >bytecodePrimGreaterOrEqual
> >> >    ...
> >> >    aBool := self primitiveFloatGreaterOrEqual: rcvr toArg: arg.
> >> >    successFlag ifTrue: [^self booleanCheat: aBool not].
> >> >
> >> >but shouldn't that be
> >> >
> >> >bytecodePrimGreaterOrEqual
> >> >    ...
> >> >    aBool := self primitiveFloatGreaterOrEqual: rcvr toArg: arg.
> >> >    successFlag ifTrue: [^self booleanCheat: aBool].
> >> >
> >> >and similarly for bytecodePrimLessOrEqual?
> >> >
> >> >- Bert -
> >> >
> >> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20090701/105be8c8/attachment.htm


More information about the Vm-dev mailing list