[Vm-dev] Integer overflow with BitBlt rule 20 and depth 32
David T. Lewis
lewis at mail.msen.com
Mon Nov 2 11:58:22 UTC 2009
On Thu, Oct 29, 2009 at 10:10:42PM -0400, David T. Lewis wrote:
> Juan provided six new tests (see Mantis 7047) that document the problems.
> I added these six tests to the trunk today, and also updated VMMaker on
> SqueakSource with Juan's fixes for bitblt simulation (mainly some memory
> access methods that had apparently been overlooked during the original
> Squeak 64 bit work).
> Juan's patches (VMMaker-BitBlt-AlphaFixes-jmv-M7407.cs on Mantis 7047)
> do resolve the problems in the VM, and the changes all look correct to me
> (but I have no experience with bitblt, so I'm just commenting on the fixes
> for type declarations and arithmetic overflow).
> Has anyone else had a chance to review this? If there are no issues or
> concerns, I will add Juan's alpha fixes to VMMaker.
Added to VMMaker-dtl.147 on SqueakSource. The new tests are now in Squeak
trunk, and corresponding fixes are in VMMaker. The issue is set to "testing"
in Mantis 7407.
More information about the Vm-dev