[Vm-dev] Re: [Pharo-project] Issue 3446 in pharo: VMMakerTool load config buttondoesn't work

[Levente Uzonyi]

On Sat, 18 Dec 2010, David T. Lewis wrote:

>
> On Sat, Dec 18, 2010 at 05:49:25AM +0100, Levente Uzonyi wrote:
>>
>> On Fri, 17 Dec 2010, David T. Lewis wrote:
>>
>>>
>>> On Fri, Dec 17, 2010 at 06:39:33PM +0100, Levente Uzonyi wrote:
>>>>
>>>> On Fri, 17 Dec 2010, Javier Pim?s wrote:
>>>>
>>>>> OK, if I'm correct the 3449 issue is fixed and integrated now. So how do
>>>>> we
>>>>> solve this one? Because the method lays on VMMakerTool's code, for
>>>>> squeak.
>>>>> Maybe we can add a line to ConfigurationOfVMMaker>>#fixVMMakerForPharo
>>>>> like
>>>>> this:
>>>
>>> <snip>
>>>
>>>>> It's a bit of a dirty hack, maybe there's a cleaner way. What do you
>>>>> think?
>>>>
>>>> No need to do dirty hacks, just communicate your needs properly. Ask David
>>>> to update the method. Squeak (since 3.9) also implements UIManager >>
>>>> #chooseFileMatching:label:. Note that the name of this method is a bit
>>>> misleading. The first argument is a list of "file extensions", not a list
>>>> of patterns. So this should work in both Squeak and Pharo:
>>>>
>>>> fileResult := UIManager default
>>>> 	chooseFileMatching: #('config')
>>>> 	label: 'Select VMMaker configuration...'.
>>>>
>>>> Since fileResult is a string that contains the full path, the variable
>>>> "file" is not necessary anymore.
>>>
>>> This is in VMMaker-dtl.211.
>>>
>>> The #saveConfig method had a similar problem, so I changed it to
>>> use UIManager>>request:initialAnswer:
>>>
>>> Both methods should work on Squeak/Pharo now.
>>
>> Thanks.
>
> Levente,
>
> Thanks for providing the fix. I also added you as a developer on
> SqueakSource/VMMaker so will be able to commit directly if you like.

Thanks David.


Levente

>
> Dave
>
>