[Vm-dev] a Cog branch
andreas.raab at gmx.de
Fri Jun 25 08:39:25 UTC 2010
On 6/25/2010 1:23 AM, Geoffroy Couprie wrote:
>> Do we have this problem? What patches do you or anyone else have that can or
>> should not be integrated in the main source?
> I have my CMake patches (to be able to build the Windows VM with
> CMake), and some patches to build the Windows VM with GCC. I sent the
> patches here 2 months ago (you never answered on that thread), and
> although people seemed interested by that code, it was never added in
> the repository. I had to store the CMake patches, and then the other
> Windows patches, and working on these different pieces of code without
> being able to commit was painful.
Sorry about this, I've been quite busy with other things (such as the
Cog release). The patches itself sound quite reasonable to me and
probably should be integrated, no?
BTW, I don't think you've ever asked for commit rights. Regarding cmake,
I have no problems giving you access so that you can keep the cmake
> I also modify the VM for self education/fun purposes, and these
> modifications would never be accepted in the main tree (heavily
> breaking large parts of the memory allocations, weird plugins, etc).
But those patches then are just as unlikely to apply to other large
changes in the main VM sources. That's a bit my point here. We've
basically got two options:
1) Everyone forks in their own little worlds, creating chaos. We've had
that in the past, it did not work AT ALL.
2) We try to be reasonable and integrate things back into the main
sources. Give people who do active development commit rights for the
relevant portions. Stay reasoable all along.
I'm *strongly* in favor of the latter.
More information about the Vm-dev