[Vm-dev] Code generator minor bug

David T. Lewis lewis at mail.msen.com
Sat Aug 27 13:38:05 UTC 2011


Hi Eliot,

This is to follow up on a code generator buglet that that I partially fixed
in VMMaker-dtl.250, and that you will want to apply in some form to oscog.
I'm attaching a change set with the VMMaker-dtl.250 version.

>From the preamble:

CCodeGenerator>> addMethodFor:selector: relies on the unspecified return
value of #addMethod (thus a CCodeGenerator, not a TMethod), then attempts
to disable inlining of the method by sending #inline: to the presumed
TMethod (actually a CCodeGenerator at this point), but #inline: is actually
a no-op in Object, so nothing happens at all.

This is the implementation from VMMaker-dtl.250, which should be applied
to oscog, possibly without the #hasDoNotGenerateStatement check, and possibly
after implementing the originally intended inline: false for macros.

Dave

-------------- next part --------------
???XN CCodeGenerator-addMethodForselector-dtl.1.cs ?V?O?8~?C???<P?n???H,??I+m+^+??$?????UB??????
???$?&???7?|3???1,~?(????Pu)??0????h??????pH/m??C?????/?`4??"?????q2??:??G???]E&?o???4D?]?+Mve?
S^???/??(????yK?
o\?G??r
???q<>;?]???N?A%?2oW"?????\bF;?m4<
?"+??A??+[??L@G??.?p???pX???3?I+V
Aj%?????U??Z?E????!e?G?
??"Z???H]+?Z?????RZ????h?Z???????|05????H?	X?Y?L?u??2EO?x????|dU+?P;?$???mn?????M?'Gx*eZ?-M?(9T,-?dlj?	Q?V??????Z???Ka/??q!%\?-?2HKL& t?=*r???Sg??Bj?'?@?????P!'?*?6?NG{q??????e??A?????r ????%??|??|?F?%'?d???@\(a-l
?????<?<?B>?O?B?Sb+A,9W????.j?Ey????-?????????}f?QG????G?)9?Y????????m?N?h??F????l?H???^o?J??'???C??1)????P???u.KC???L4E??D?%?J?l?????s??kQq?i?{?????.??o??
+????????1p??.?????x?gx?5??/I?s
?0????F?q???~???]y?4|?^/??6_?rI?iG?????0y??n??2?B?Q???????"?lZd?Q?e?C?W???y????(???IE?9?A?_q???
G??B?????.%3??G?&???????}?s?????????i??o??_?yM??,?B????? _i?= ?;???<w?????n?d??1N??o??UE?????o?????I??L|??2?!???w?huSc???\????W??????????????v???m]???;v???g????????9(?pz1z???J2dDA???gq?F?c7????????
r?????kX??f???u?T???6???U?f???vA_-??~ ????O_??EF??????Q??)???
?}}????/????)
  


More information about the Vm-dev mailing list