[Vm-dev] linux build stability

David T. Lewis lewis at mail.msen.com
Wed Feb 2 23:07:03 UTC 2011


> 
> Or some concurrency issue, because hearbeat runs in separate thread
> than vm thread.

Hmmm... That's a thought. This is a complete shot in the dark, but the
following does not look thread safe to me:

  static void
  high_performance_tick_handler(int sig, struct siginfo *sig_info, void *context)
  {
  static int tickCheckInProgress;
  
          if (tickCheckInProgress) return;
  
          tickCheckInProgress = 1;
          checkHighPriorityTickees(ioUTCMicroseconds());
          tickCheckInProgress = 0;
  }

This should be using a mutex, no?

Dave



More information about the Vm-dev mailing list