[Vm-dev] Fix for UUID library crashes

Levente Uzonyi leves at elte.hu
Thu Feb 17 03:43:49 UTC 2011


On Tue, 15 Feb 2011, Eliot Miranda wrote:

> On Tue, Feb 15, 2011 at 5:24 PM, David T. Lewis <lewis at mail.msen.com> wrote:
>
>>
>> Ian, Eliot:
>>
>> The attached platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c is a fix
>> for the UUID library crash bug, provided by Levente Uzoni.
>
>
> chomp. Thanks Levente; this makes perfect sense.  It'll be included in the
> next OSCog build.

Thanks. Before you add it, take a look at Ian's changes, which make the 
code more readable and I guess follow the style of the VM sources better 
than my version. And the signal handler function should have been declared 
as static:
http://squeakvm.org/cgi-bin/viewcvs.cgi/trunk/platforms/unix/plugins/UUIDPlugin/sqUnixUUID.c?rev=2362&view=auto


Levente

>
>
>> While I
>> cannot confirm that it prevents crashes (since I have never encountered
>> one myself), I can confirm that it builds and runs and that the
>> proposed solution looks entirely plausible.
>>
>> Actually, it's way more that just plausible: This one gets my vote
>> for Best Creative Hack Of The Year. Thank you Levente!
>>
>> The bug report including Levente's patch is at:
>>  http://bugs.squeak.org/view.php?id=7358
>>
>> Dave
>>
>>
>>
>


More information about the Vm-dev mailing list