[Vm-dev] Rename #isIntegerObject: and friends

[Mariano Martinez Peck]

On Thu, Mar 10, 2011 at 11:50 AM, Eliot Miranda <eliot.miranda at gmail.com>wrote:

>
>
> On Tue, Mar 8, 2011 at 12:00 AM, Mariano Martinez Peck <
> marianopeck at gmail.com> wrote:
>
>>
>> Hi guys. I notice that most of the times, the usage of #isIntegerObject:
>> is for checking whether the object is immediate or not, rather than if it is
>> an Integer.
>> In addition, when we will have 64 bits, I guess we will encode more
>> objects (small floats, dates, points, etc) than just integers...
>>
>
> +1.  When I add immediate characters I will do this.  I also did this when
> I ported the Slang plugin system to VisualWorks in order to steal the
> WarpBlt plugin.
>
>

excellent,


>
>> So, what about renaming #isIntegerObjects: and friends to something like
>> #isImmediateObject:   ?  I know that changing #isIntegerObject: or things
>> like that is too heavy, but maybe we can start by deprecating it, or for the
>> new code, to use #isImmediateObject:   instead... so we start preparing
>> ourselves for the future, in little steps.
>>
>
> I like isImmediate:.
>
>

Good. The only thing I would do is to take care where isIntegerObject: is
used to really know if the object is an integer (not immediae). Maybe you do
a kind of automatic refactor hehehe

cheers

mariano


>
>> cheers
>>
>> Mariano
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20110310/fd9fbb08/attachment.htm