[Vm-dev] Bug in unix/vm/sqUnixExternalPrims.c

[Stefan Marr]

Hi:

I belief there is a small bug in ioLoadModule as it is currently in the SVN:

http://squeakvm.org/cgi-bin/viewcvs.cgi/trunk/platforms/unix/vm/sqUnixExternalPrims.c?rev=2375&view=auto

Line 314 reads currently like:

       if ((handle= tryLoading("", path)))


The context:
	fdebugf((stderr, "ioLoadModule plugins = %s\n                path = %s\n",
		 squeakPlugins, path));
	if ((handle= tryLoading("", path)))
	  return handle;
	*out++= '/';
	*out= '\0';


While it should read:
       if ((handle= tryLoading(path, "")))

At least according to the arguments names and all other uses, that is.

The signature is:
       static void *tryLoading(char *dirName, char *moduleName)


While that stuff is in the #else branch and might not be used by you guys, it is still there, buggy, and actually used at least in the RoarVM.

Best regards
Stefan


-- 
Stefan Marr
Software Languages Lab
Vrije Universiteit Brussel
Pleinlaan 2 / B-1050 Brussels / Belgium
http://soft.vub.ac.be/~smarr
Phone: +32 2 629 2974
Fax:   +32 2 629 3525