[Vm-dev] [Cog] Cannot generate code anymore
Eliot Miranda
eliot.miranda at gmail.com
Fri Dec 21 21:09:15 UTC 2012
Igor,
quite so. Perhaps I'll have time to change this soon. SHouldn't be
hard. The test is straight-forward. if after the change the system spits
out unchanged source it is working :)
On Wed, Dec 19, 2012 at 7:12 PM, Igor Stasenko <siguctua at gmail.com> wrote:
>
> yeah.. just looked again at #buildCodeGeneratorForCogit: getAPIMethods
>
>
> cogitClasses := OrderedCollection new.
> [cogitClasses addFirst: cogitClass.
> cogitClass ~~ Cogit
> and: [cogitClass inheritsFrom: Cogit]] whileTrue:
> [cogitClass := cogitClass superclass].
> cogitClasses addFirst: VMClass.
> cogitClasses addAllLast: self cogitClass ancilliaryClasses.
> cogitClasses do: [:cgc| cg addClass: cgc].
> (cg structClassesForTranslationClasses: cogitClasses) do:
> [:structClass| cg addStructClass: structClass].
>
> see what wrong there?
>
> it letting vmmaker to decide for a class what to do, instead letting
> class to decide for itself.
> This logic is clearly do not belongs to right place.
>
--
best,
Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20121221/d4f50c01/attachment-0001.htm
More information about the Vm-dev
mailing list