[Vm-dev] [squeak-dev] VM 4.4 build nastinesses - part 1 of probably many

[Eliot Miranda]

Tim,

    that got fixed in Cog on 11/26/2012 (the addressOf: was my bad in
the first place).  Install the fixed version.  Find attached.

On Wed, Feb 13, 2013 at 4:42 PM, tim Rowledge <tim at rowledge.org> wrote:
>
>
> On 13-02-2013, at 3:46 PM, Eliot Miranda <eliot.miranda at gmail.com> wrote:
>>>> Surely if one were using &foo the cdecl ought to be foo(SQFile * bar) ?
>>
>>
>> In my code base I never use &fileRecords, only fileRecords.  Where's
>> the sqFileStdioHandlesInto(& filesRecords) call?  IMO it's wrong.
>>
> primitiveFileStdioHandles
>         "Answer an Array of file handles for standard in, standard out and standard error,
>          with nil in entries that are unvailable, e.g. because the platform does not provide
>          standard error, etc.  Fail if there are no standard i/o facilities on the platform or
>          if the security plugin denies access or if memory runs out."
>         | fileRecords result validMask |
>         <export: true>
>         <var: 'fileRecords' declareC: 'SQFile fileRecords[3]'>
>         sHFAfn ~= 0 ifTrue:
>                 [(self cCode: ' ((sqInt (*)(void))sHFAfn)()' inSmalltalk: [true]) ifFalse:
>                         [^interpreterProxy primitiveFail]].
>         validMask := self sqFileStdioHandlesInto: (self addressOf: fileRecords).
> [snip]
>
>
> tim
> --
> tim Rowledge; tim at rowledge.org; http://www.rowledge.org/tim
> Strange OpCodes: ARG: Agree to Run Garbage
>
>



-- 
best,
Eliot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FilePlugin-primitiveFileStdioHandles.st
Type: application/octet-stream
Size: 2252 bytes
Desc: not available
Url : http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20130219/99560baf/FilePlugin-primitiveFileStdioHandles.obj