[Vm-dev] VM Maker: VMMaker-dtl.294.mcz

commits at source.squeak.org commits at source.squeak.org
Fri Jan 4 04:54:02 UTC 2013

David T. Lewis uploaded a new version of VMMaker to project VM Maker:

==================== Summary ====================

Name: VMMaker-dtl.294
Author: dtl
Time: 3 January 2013, 11:50:21.809 pm
UUID: f4540612-7d99-4520-8a31-f689304b18cc
Ancestors: VMMaker-dtl.293

VMMaker 4.10.8

Add missing comment generation for TStmtListNode. This provides additional embedded comments in generated C source.


A recent change to the compiler in Squeak trunk causes comments to be associated with statement lists rather than assignment nodes if the comment appears at the beginning of a block. This is a worthwhile change, but it exposes a bug in C code generation in which these comments are lost from from generated C code.

This update restores the expected generation of comments at the beginning of blocks when VMMaker is run in updated Squeak images. It also results in additional embedded comments in various places throughout the generated C sources.

There is no functional impact on generated code, and the bug is not present in the oscog branch of VMMaker.

=============== Diff against VMMaker-dtl.293 ===============

Item was changed:
  ----- Method: TStmtListNode>>emitCCodeOn:level:generator: (in category 'as yet unclassified') -----
  emitCCodeOn: aStream level: level generator: aCodeGen
+ 	self emitCCommentOn: aStream level: level.
  	statements do: [:s |
  		s emitCCommentOn: aStream level: level.
  		aStream tab: level.
  		s emitCCodeOn: aStream level: level generator: aCodeGen.
  		(((self endsWithCloseBracket: aStream) not
  			and: [(s isComment) not])
  				and: [s requiresCLineTerminator])
  			ifTrue: [aStream nextPut: $;].
  		aStream cr].

Item was changed:
  ----- Method: VMMaker class>>versionString (in category 'version testing') -----
  	"VMMaker versionString"
+ 	^'4.10.8'!
- 	^'4.10.7'!

More information about the Vm-dev mailing list