[Vm-dev] Cross file updates

[David T. Lewis]

On Wed, Mar 06, 2013 at 10:33:44AM -0800, tim Rowledge wrote:
> 
> 
> On 06-03-2013, at 5:20 AM, "David T. Lewis" <lewis at mail.msen.com> wrote:
> 
> > 
> > On Tue, Mar 05, 2013 at 08:39:32PM -0800, tim Rowledge wrote:
> >> 
> >> I've just committed some changes to the Cross platform files that should have no effect for anything but the Acorn code.
> >> I had to fudge a definition of fileno() so that the push/popOutputFile stuff would compile.
> >> Added a decl for ioSetCursorARGB()
> >> Fudged FilePlugin.h for ACORN to keep a long for my (ab)use of the lastOp field.
> >> Fixed a mismatched decl for ioShowDisplayOnWindow() in HostWindowPlugin.h
> >> SVN thinks there are a few other lines changed even though I can't find any difference even with a binary editor.
> >> 
> > 
> > Mr. Jenkins is of the opinion that we need to follow up on other platforms:
> > 
> >  http://build.squeak.org/job/InterpreterVM/
> > 
> > I'm not sure about Windows and Mac, but on Unix the issue is here:
> 
> Interesting - the reason I had to make that change was because I got the equivalent complaint. I don't care much whether we actually use int or char since it's just a pointer to the bitmap that gets dereferenced. It's quite a while since I did that bit so I'm not sure what my reason was for making a choice one way or the other. I'll look after gym.
>

I'll check also as soon as I get a chance, just did not have time this morning.

I'm quite sure that the unix platform code needed an update anyway, as I think
I recall seeing this when I was checking for 64-bit cleanliness a few years ago.

BTW, I really want to put FFI back on top of the to-do list for 64-bit fixing,
as I think it is currently the biggest inhibitor to getting clean VM builds
in 64-bit mode, and nowadays folks are beginning to expect that sort of thing
to just work. 

Dave