[Vm-dev] Re: Long path name support added for win32

Nicolai Hess nicolaihess at web.de
Thu Mar 19 23:39:45 UTC 2015


2014-12-19 4:31 GMT+01:00 David T. Lewis <lewis at mail.msen.com>:

>
> Hi Marcel,
>
> Thanks for doing this.
>
> I opened a Mantis issue so that we will not forget to integrate your
> changes:
>
>   http://bugs.squeak.org/view.php?id=7825
>
> Currently, the SVN trunk and oscog branches are identical for
> sqWin32FilePrims.c,
> so your update can be applied to both.
>
> Your update in the file header looks fine to me. It does not affect
> copyright,
> you are just adding a comment to document your update, which is great:
>
> *   UPDATES:
> *     1) Support for long path names added by using UNC prefix in that case
> *        (Marcel Taeumel, Hasso Plattner Institute, Postdam, Germany)
>
> Eliot - I am not able to test this, but I am sure that Marcel has done so.
> If this looks good to you then I think we should commit the update to both
> oscog and trunk in SVN. I think we both have write access to the win32 tree
> in SVN trunk, so I'm happy to make the update if you agree (or I think you
> can
> do it also if you prefer, whichever is easier).
>
> I'll close out the Mantis issue whenever we get this completed.
>
> Thanks,
> Dave
>
>
>
> On Tue, Dec 16, 2014 at 12:59:05AM -0800, Marcel Taeumel wrote:
> >
> > sqWin32FilePrims.c <
> http://forum.world.st/file/n4796107/sqWin32FilePrims.c>
> >
> > Hi, Eliot! :)
> >
> > Here is the second version that uses alloca. I also modified FAIL to
> > represent a block thinking of Heartbleed. :D I am not that much into C
> > patterns. You are free change that.
> >
> > Another thing is about the copyright information at the beginning of the
> > file. I added something, but what is the correct format?
> >
> > Best,
> > Marcel
> >
> >
> >
> > --
> > View this message in context:
> http://forum.world.st/Long-path-name-support-added-for-win32-tp4796045p4796107.html
> > Sent from the Squeak VM mailing list archive at Nabble.com.
>


I just found this because I tried to add long path support to pharo.
What about methods for working with directories dir_create/dir_lookup ....
Don't you need to do the same in sqWin32Directory.c ?

nicolai
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20150320/d662d338/attachment.htm


More information about the Vm-dev mailing list