[Vm-dev] SqueakSSL + SAN certificates

[Tobias Pape]

On 27.05.2015, at 19:25, Levente Uzonyi <leves at elte.hu> wrote:

> Hi Tobias,
> 
> On Wed, 27 May 2015, Tobias Pape wrote:
> 
>> 
>> Hi Levente,
>> 
>> On 26.05.2015, at 23:55, Levente Uzonyi <leves at elte.hu> wrote:
>> 
>>> Hi All,
>>> 
>>> I've implemented support for reading the domain names from the certificate's SAN extension[1] in SqueakSSL.
>>> The image side code is in the Inbox[2]. It is backwards compatible -- everything works as before without the VM changes.
>>> I've also uploaded the modified files[3][4] for the unix platform, and a diff[5] (which somehow doesn't include the changes of the .h file).
>>> 
>>> The VM support code for other platforms are to be done.
>>> 
>>> These changes fix the failing SqueakSSL test in the Trunk, so I suggest including the .mcz file in the 4.6 release.
>>> 
>>> Levente
>>> 
>>> [1] https://en.wikipedia.org/wiki/SubjectAltName
>>> [2] http://lists.squeakfoundation.org/pipermail/squeak-dev/2015-May/184581.html
>>> [3] http://leves.web.elte.hu/squeak/SqueakSSL/SqueakSSL.h
>>> [4] http://leves.web.elte.hu/squeak/SqueakSSL/sqUnixOpenSSL.c
>>> [5] http://leves.web.elte.hu/squeak/SqueakSSL/diff.txt
>> 
>> What about a pull-request to the gitHub repo[1]?
> 
> Done. I saw that the code there is different from the code in the svn repository. Why is that?
> One important difference is that it has a memory leak, which is not present in the svn repo. It's also fixed in the pull-request.
> 

Thanks. Comments in the PR :D

Best regards
	-Tobias
> Levente
> 
>> 
>> Best regards
>> 	-Tobias
>> 
>> [1]: https://github.com/itsmeront/squeakssl