[Vm-dev] Re: [Pharo-dev] issue with large file path on windows

Nicolai Hess nicolaihess at web.de
Fri Sep 11 07:48:29 UTC 2015


2015-09-11 9:44 GMT+02:00 Nicolai Hess <nicolaihess at web.de>:

>
>
> 2015-09-11 9:43 GMT+02:00 Nicolai Hess <nicolaihess at web.de>:
>
>>
>>
>> 2015-09-10 23:07 GMT+02:00 Eliot Miranda <eliot.miranda at gmail.com>:
>>
>>>
>>> Hi Nicolai,
>>>
>>> On Thu, Sep 10, 2015 at 1:17 PM, Nicolai Hess <nicolaihess at web.de>
>>> wrote:
>>>
>>>>
>>>>
>>>>
>>>> 2015-09-10 21:31 GMT+02:00 Eliot Miranda <eliot.miranda at gmail.com>:
>>>>
>>>>>
>>>>> Hi Nicolai,
>>>>>
>>>>>     I'm a bit concerned that this is creating drift with the
>>>>> "official" Cog source base at
>>>>> http://www.squeakvm.org/svn/squeak/branches/Cog.  Long filename
>>>>> support for win32 was recently added by Marcel Taumel in May of this year.
>>>>> Are you tracking that?  How can we keep the sources harmonized?
>>>>>
>>>>
>>>> Yes, I know, and I already asked on the ML if we can take that change or
>>>> if it is not possible because we have already other changes (pharos
>>>> file plugin
>>>> provides addition attributes (the file permissions)).
>>>>
>>>
>>> Esteban and I just harmonized this.  I'm (almost correctly) generating
>>> the plugin source such that one can define either PharoVM or not to chose
>>> between the different versions.  I say "almost" because I'm currently
>>> spitting out
>>>
>>> #define PharoVM 0
>>> ...
>>> #if PharoVM
>>>
>>> instead of
>>>
>>> #if !defined(PharoVM)
>>> #   define PharoVM 0
>>> #endif
>>> ...
>>> #if PharoVM
>>>
>>> but I'll fix it v soon.
>>>
>>
>> OK, I'll try to copy marcels solution
>>
>>
>>>
>>> But I got no response, so I tried to adopt Marcels change.
>>>>
>>>> And I only found the change for sqWin32FilePrims.c, but missed the
>>>> other change
>>>> that is necessary in sqWin32Directory.c (and asked on the ML). In the
>>>> meantime Marcel added this but I could not find
>>>> the changed source, only an updated vm.
>>>> Is this change already comitted?
>>>>
>>>
>>> Yes, see
>>> http://www.squeakvm.org/svn/squeak/branches/Cog/platforms/win32/vm/sqWin32Directory.c
>>>
>>
>> Ah, good. Now (I must be blind, but) I can not see the other change,
>> shouldn't there
>> be a "plugins" folder in Cog/platforms/win32/?
>> Where are the changes to sqWin32FilePrims.c now?
>>
>
> Ok, found it. It is in the trunk branch :)
>


No, wait, now I am confused. The change to sqWin32FilePrims.c is only in
the trunk branch and the change to sqWin32Directory.c is
only in the Cog branch. What branch includes the solution for both
(sqWin32Directory.c and sqWin32FilePrims.c) and should be
used for a merge into pharos vm repository?



>
>
>
>>
>>
>>
>>
>>>
>>> I'm sorry I didn't see your message.  Did you ask on vm-dev?
>>>
>>
>> I am not sure, maybe I only send it in the squeak-dev list
>>
>>
>>>
>>>
>>>
>>>> I would love if someone else got this working.
>>>>
>>>
>>> :-)  I hear you :-)
>>>
>>>
>>>
>>>>
>>>> nicolai
>>>>
>>>>
>>>>
>>>>>
>>>>> On Sun, Aug 23, 2015 at 4:44 AM, Nicolai Hess <nicolaihess at web.de>
>>>>> wrote:
>>>>>
>>>>>> For those who had problems with pharo on windows and github based
>>>>>> repositories,
>>>>>> I built a windows vm with support for long paths:
>>>>>>
>>>>>>
>>>>>> https://drive.google.com/file/d/0B8yEahnuIem2bmxwdzJuUXFxVGM/view?usp=sharing
>>>>>>
>>>>>>
>>>>>> For browsing directories with large paths (FileList or Inspect),
>>>>>> you may need one additional change in the image (But I am not really
>>>>>> sure about that) :
>>>>>>
>>>>>> DiskStore>>initialize
>>>>>>     super initialize.
>>>>>>     maxFileNameLength := Smalltalk vm maxFilenameLength ifNil: [
>>>>>> 32767 ].
>>>>>>
>>>>>>
>>>>>> please test and give feedback.
>>>>>>
>>>>>> This wasn't as easy as I thought, and I had to make some more changes
>>>>>> for the file permissions (the stat-functions don't work for files
>>>>>> with long paths).
>>>>>> Please test other file/folder operations.
>>>>>>
>>>>>>
>>>>>> nicolai
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> _,,,^..^,,,_
>>>>> best, Eliot
>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> _,,,^..^,,,_
>>> best, Eliot
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20150911/dead2b30/attachment-0001.htm


More information about the Vm-dev mailing list