[Vm-dev] VM Maker: VMMaker.oscog-eem.1451.mcz

commits at source.squeak.org commits at source.squeak.org
Mon Sep 14 21:50:36 UTC 2015


Eliot Miranda uploaded a new version of VMMaker to project VM Maker:
http://source.squeak.org/VMMaker/VMMaker.oscog-eem.1451.mcz

==================== Summary ====================

Name: VMMaker.oscog-eem.1451
Author: eem
Time: 14 September 2015, 2:48:26.684 pm
UUID: 35560bfb-1823-47e2-a964-8906c9d43890
Ancestors: VMMaker.oscog-eem.1450

Oops! The has hash arm of primitiveSetOrHasIdentityHash needs to return, not fall through.

=============== Diff against VMMaker.oscog-eem.1450 ===============

Item was changed:
  ----- Method: InterpreterPrimitives>>primitiveSetOrHasIdentityHash (in category 'object access primitives') -----
  primitiveSetOrHasIdentityHash
  	| hash oldHash thisReceiver |
  	argumentCount = 0 ifTrue:
  		[| hasHash |
  		 hasHash := (objectMemory isNonImmediate: self stackTop)
  						and: [objectMemory hasIdentityHash: self stackTop].
+ 		 self pop: argumentCount + 1 thenPushBool: hasHash.
+ 		 ^self].
- 		 self pop: argumentCount + 1 thenPushBool: hasHash].
  	hash := self stackIntegerValue: 0.
  	thisReceiver := self stackObjectValue: 1.
  	self successful ifTrue:
  		[oldHash := objectMemory hashBitsOf: thisReceiver.
  		 objectMemory setHashBitsOf: thisReceiver to: hash.
  		 self pop: argumentCount + 1 thenPushInteger: oldHash]!



More information about the Vm-dev mailing list