[Vm-dev] Re: [Pharo-dev] issue with large file path on windows

Nicolai Hess nicolaihess at web.de
Tue Sep 15 07:19:33 UTC 2015


2015-09-14 23:10 GMT+02:00 Eliot Miranda <eliot.miranda at gmail.com>:

>
> Thanks Nicolai, that's great!  I'll merge in your changes.  Which files do
> I need to look at?
>

I changed (removed my code, added Marcels)
platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c
platforms/win32/vm/sqWin32.h
platforms/win32/vm/sqWin32Directory.c

I added (should be the same as in squeak vm repository)
platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c


But my changes only about that code that already is in squeaks repository.

If we want to merge some of the pharo-vm code into squeaks branch, we
first need to wrap that code with some #ifdefs

(For the win32 file/directory stuff, this would be code in
platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c
platforms/win32/vm/sqWin32.h
platforms/win32/vm/sqWin32Directory.c
and
platforms/Cross/plugins/FilePlugin/FilePlugin.h)

Maybe Estaban should look at this, and tell which path he would follow  to
merge those changes.





>
> On Sat, Sep 12, 2015 at 8:00 AM, Nicolai Hess <nicolaihess at web.de> wrote:
>
>>
>>
>>
>> 2015-09-10 21:31 GMT+02:00 Eliot Miranda <eliot.miranda at gmail.com>:
>>
>>>
>>> Hi Nicolai,
>>>
>>>     I'm a bit concerned that this is creating drift with the "official"
>>> Cog source base at http://www.squeakvm.org/svn/squeak/branches/Cog.
>>> Long filename support for win32 was recently added by Marcel Taumel in May
>>> of this year.  Are you tracking that?  How can we keep the sources
>>> harmonized?
>>>
>>
>> Ok, I removed all of my code again and merged with sqWin32Directory.c and
>> sqWin32FilePrims.c from the official cog source.
>> I left only pharos additions for the fileattributes (posixpermissions)
>> this should make it easier to merge which the
>> squeak vm main branch (wrapped with pharo vm ifdefs).
>>
>> github branch:
>> https://github.com/nicolaihess/pharo-vm/tree/harmonize_win_file_plugin
>> I'll create a push request.
>>
>>
>> nicolai
>>
>>
>>
>>>
>>> On Sun, Aug 23, 2015 at 4:44 AM, Nicolai Hess <nicolaihess at web.de>
>>> wrote:
>>>
>>>> For those who had problems with pharo on windows and github based
>>>> repositories,
>>>> I built a windows vm with support for long paths:
>>>>
>>>>
>>>> https://drive.google.com/file/d/0B8yEahnuIem2bmxwdzJuUXFxVGM/view?usp=sharing
>>>>
>>>>
>>>> For browsing directories with large paths (FileList or Inspect),
>>>> you may need one additional change in the image (But I am not really
>>>> sure about that) :
>>>>
>>>> DiskStore>>initialize
>>>>     super initialize.
>>>>     maxFileNameLength := Smalltalk vm maxFilenameLength ifNil: [ 32767
>>>> ].
>>>>
>>>>
>>>> please test and give feedback.
>>>>
>>>> This wasn't as easy as I thought, and I had to make some more changes
>>>> for the file permissions (the stat-functions don't work for files with
>>>> long paths).
>>>> Please test other file/folder operations.
>>>>
>>>>
>>>> nicolai
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> _,,,^..^,,,_
>>> best, Eliot
>>>
>>>
>>
>>
>
>
> --
> _,,,^..^,,,_
> best, Eliot
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20150915/2dff0882/attachment-0001.htm


More information about the Vm-dev mailing list