[Vm-dev] Re: [OpenSmalltalk/opensmalltalk-vm] Prepare Cocoa VM for High-DPI (#22)

[Tobias Pape]

On 06.07.2016, at 22:18, John McIntosh <johnmci at smalltalkconsulting.com> wrote:

> >Works for both OpenGL and CoreGraphics backends (Why do we have both?)
> 
> Originally the code was written for CoreGraphics as a port from the original QuickDraw 1984 era logic but used CALayers to improve performance. 
> The open/GL logic was added as part of the development process but at the time Apple was transitioning to versions of OpenGL/ES etc so I left both in as part of the transition process. 
> Today the graphics layer could look at Metal as an alternate solution. 
> 

That's good to know!
I tested both ways and it turns out both work well, I have not done perf measurings, however.
The OpenGL one needs a opt-in for high-dpi, the CG one does not.
Aside from what is the default now, what would your pick be?

Best regards
	-Tobias

PS: I'll merge that now

> 
> On Tue, Jul 5, 2016 at 11:27 PM, Eliot Miranda <eliot.miranda at gmail.com> wrote:
>  
> Hi Tobias,
> 
>     I'm confused by https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/142601096.  Who do I see the errors?  The red link to the right simply points back to the same page.
> 
> On Tue, Jul 5, 2016 at 2:56 PM, Tobias Pape <notifications at github.com> wrote:
> 	• Works for both OpenGL and CoreGraphics backends (Why do we have both?)
> 		• Needs new abstractions for 'squeak-screen-size' and 'squeak-mouse-position' in both backends/view. Is provided.
> You can view, comment on, or merge this pull request online at:
> 
>   https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22
> 
> Commit Summary
> 
> 	• Prepare Cocoa VM for High-DPI
> File Changes
> 
> 	• M platforms/iOS/vm/Common/Classes/sqSqueakScreenAndWindow.m (6)
> 	• M platforms/iOS/vm/OSX/Squeak-Info.plist (2)
> 	• M platforms/iOS/vm/OSX/sqSqueakOSXApplication+events.m (4)
> 	• M platforms/iOS/vm/OSX/sqSqueakOSXApplication.m (3)
> 	• M platforms/iOS/vm/OSX/sqSqueakOSXCGView.h (2)
> 	• M platforms/iOS/vm/OSX/sqSqueakOSXCGView.m (130)
> 	• M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.h (2)
> 	• M platforms/iOS/vm/OSX/sqSqueakOSXOpenGLView.m (54)
> 	• M platforms/iOS/vm/OSX/sqSqueakOSXView.h (3)
> 	• M platforms/iOS/vm/iPhone/Classes/SqueakUIView.h (2)
> 	• M platforms/iOS/vm/iPhone/Classes/SqueakUIView.m (8)
> Patch Links:
> 
> 	• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.patch
> 	• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/22.diff
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.