[Vm-dev] [commit][3704] converting int to pointer is 64bits risky,
better use long even for dummy
Eliot Miranda
eliot.miranda at gmail.com
Fri May 6 22:20:14 UTC 2016
> On May 6, 2016, at 1:37 PM, commits at squeakvm.org wrote:
>
>
> Revision: 3704
> Author: nice
> Date: 2016-05-06 13:37:49 -0700 (Fri, 06 May 2016)
> Log Message:
> -----------
> converting int to pointer is 64bits risky, better use long even for dummy
It isn't risky, it's broken :-)
>
> Modified Paths:
> --------------
> branches/Cog/platforms/iOS/plugins/SqueakFFIPrims/dummyFFI.c
> branches/Cog/platforms/iOS/vm/iPhone/plugins/SqueakFFIPrims/dummyFFI.c
>
> Modified: branches/Cog/platforms/iOS/plugins/SqueakFFIPrims/dummyFFI.c
> ===================================================================
> --- branches/Cog/platforms/iOS/plugins/SqueakFFIPrims/dummyFFI.c 2016-05-06 20:22:49 UTC (rev 3703)
> +++ branches/Cog/platforms/iOS/plugins/SqueakFFIPrims/dummyFFI.c 2016-05-06 20:37:49 UTC (rev 3704)
> @@ -157,7 +157,7 @@
>
> /* ffiFree:
> Free space from the external heap */
> -int ffiFree(int pointer)
> +int ffiFree(long pointer)
> {
> return 1;
> }
>
> Modified: branches/Cog/platforms/iOS/vm/iPhone/plugins/SqueakFFIPrims/dummyFFI.c
> ===================================================================
> --- branches/Cog/platforms/iOS/vm/iPhone/plugins/SqueakFFIPrims/dummyFFI.c 2016-05-06 20:22:49 UTC (rev 3703)
> +++ branches/Cog/platforms/iOS/vm/iPhone/plugins/SqueakFFIPrims/dummyFFI.c 2016-05-06 20:37:49 UTC (rev 3704)
> @@ -157,7 +157,7 @@
> }
>
>
> -int ffiFree(int ptr)
> +int ffiFree(long ptr)
> {
> if (ptr) free((void *)ptr);
> return 1;
>
More information about the Vm-dev
mailing list