[Vm-dev] DSAPrims broken on 64-bit VM (3684)

[Nicolas Cellier]

Hi Levente,
looking at code, my wild guess (but I did not try) is that #leftRotate:by:
is incorrectly inlined...
The parameter should be cast to unsigned int (32 bits) otherwise extra bits
will pollute the result.
Unfortunately, this method get inlined with sqInt argument which are 64bits
long in 64bits version...
We really need to fix inlining.
I'll try with <inline: #never> if I have time to confirm/infirm the guess...




2016-05-13 13:07 GMT+02:00 Levente Uzonyi <leves at caesar.elte.hu>:

>
> Hi All,
>
> As the subject says, the primitives work, but the SecureHashAlgorithmTests
> fail, because the prims miscalculate the values. I guess this is another
> integer type issue.
>
> Levente
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20160513/046371ac/attachment.htm