[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 8c0091: Remove unused declaration

[GitHub]

  Branch: refs/heads/less_warnings_20161112
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 8c0091a2a1b63c8858f29b6ea146ce927000fe80
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/8c0091a2a1b63c8858f29b6ea146ce927000fe80
  Author: nicolas-cellier-aka-nice <nicolas.cellier.aka.nice at gmail.com>
  Date:   2016-11-12 (Sat, 12 Nov 2016)

  Changed paths:
    M platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c

  Log Message:
  -----------
  Remove unused declaration


  Commit: d2d319a7f319ab365c07cc40ab35b38ee7751988
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/d2d319a7f319ab365c07cc40ab35b38ee7751988
  Author: nicolas-cellier-aka-nice <nicolas.cellier.aka.nice at gmail.com>
  Date:   2016-11-12 (Sat, 12 Nov 2016)

  Changed paths:
    M platforms/win32/plugins/SecurityPlugin/sqWin32Security.c

  Log Message:
  -----------
  Remove an unused variable declaration


  Commit: 87b57297ca6b26272f9070b0a07994f5ad7c88f5
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/87b57297ca6b26272f9070b0a07994f5ad7c88f5
  Author: nicolas-cellier-aka-nice <nicolas.cellier.aka.nice at gmail.com>
  Date:   2016-11-12 (Sat, 12 Nov 2016)

  Changed paths:
    M platforms/win32/plugins/SoundPlugin/sqWin32Sound.c
    M platforms/win32/vm/sqWin32Backtrace.c

  Log Message:
  -----------
  Remove a few signed/unsigned mismatch warnings


  Commit: 3d65dbc59020928a2fd430e115696dda038d517e
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/3d65dbc59020928a2fd430e115696dda038d517e
  Author: nicolas-cellier-aka-nice <nicolas.cellier.aka.nice at gmail.com>
  Date:   2016-11-12 (Sat, 12 Nov 2016)

  Changed paths:
    M platforms/win32/plugins/DropPlugin/sqWin32Drop.c

  Log Message:
  -----------
  Fix prototype for dropRequestFileHandle

it expects sqInt parameter and answer sqInt
Also make numDropFiles unsigned, it ain't gonna be negated, and this will remove signed/unsigned mismatch warnings
Also sqFileOpen expect a char *, so don't cast the dropName to sqInt unecessarily, this will avoid a int/pointer conversion warning


  Commit: fb4a748d4cd1be1f94df6ee0c92edc0cf037c04d
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/fb4a748d4cd1be1f94df6ee0c92edc0cf037c04d
  Author: nicolas-cellier-aka-nice <nicolas.cellier.aka.nice at gmail.com>
  Date:   2016-11-12 (Sat, 12 Nov 2016)

  Changed paths:
    M platforms/win32/plugins/HostWindowPlugin/sqWin32HostWindowPlugin.c

  Log Message:
  -----------
  Fix a int/pointer conversion warning


  Commit: c6a14f855ff1aa46942eb4afef6b0beaff17f662
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/c6a14f855ff1aa46942eb4afef6b0beaff17f662
  Author: nicolas-cellier-aka-nice <nicolas.cellier.aka.nice at gmail.com>
  Date:   2016-11-12 (Sat, 12 Nov 2016)

  Changed paths:
    M platforms/Cross/plugins/BitBltPlugin/BitBltGeneric.c

  Log Message:
  -----------
  Remove a Compiler warning in BitBltGeneric.c

Some compiler complain that we truncate the 64bit pointer to 32bit int.
This warning might disappear if we explicitely cancel the high bits (bitand with appropriate mask), at least it does in MSVC2015.


  Commit: cb4b5c3a9624e58a07a93333eb93190ad9c01dc0
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/cb4b5c3a9624e58a07a93333eb93190ad9c01dc0
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2016-11-12 (Sat, 12 Nov 2016)

  Changed paths:
    M platforms/win32/plugins/HostWindowPlugin/sqWin32HostWindowPlugin.c
    M platforms/win32/plugins/MIDIPlugin/sqWin32MIDI.c
    M platforms/win32/vm/sqWin32Window.c

  Log Message:
  -----------
  Cosmetic use { } to remove warning about possible ambiguous nested if/else constructs


  Commit: 6b428eb8c3fbcf6f30e4814600908f302cc58240
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/6b428eb8c3fbcf6f30e4814600908f302cc58240
  Author: Nicolas Cellier <nicolas.cellier at sirehna.com>
  Date:   2016-11-12 (Sat, 12 Nov 2016)

  Changed paths:
    M platforms/win32/plugins/JoystickTabletPlugin/sqWin32Joystick.c

  Log Message:
  -----------
  Cosmetic: move extern function prototypes upward in file rather than inside functions

There is no such thing as nested function prototypes.
Ideally all these prototypes should be moved in some header


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/8c0091a2a1b6^...6b428eb8c3fb