[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] b14f85: [SqueakSSL] fix endless recursion on failes connec...

[Eliot Miranda]

Hi Guys,

    I notice that carriage returns are creeping into files, presumably
because you're editing on Wndows with editors that insert CR+LF at
line-endf instead of line-end.  Sorry to be so anal but can we try and
avoid CRs in the C source?

TIA

diff --git a/platforms/Mac OS/plugins/SqueakSSL/sqMacSSL.c b/platforms/Mac
OS/pl
index 3a78d06..a1a8891 100644
--- a/platforms/Mac OS/plugins/SqueakSSL/sqMacSSL.c
+++ b/platforms/Mac OS/plugins/SqueakSSL/sqMacSSL.c
@@ -289,12 +289,12 @@ sqInt sqCreateSSL(void)

     if (handle >= handleMax) {
         const int delta = 100;
+               int i;*^M*
         /* Resize the handle buffer */
         handleBuf = (sqSSL**)realloc(handleBuf,
                                      (handleMax + delta) * sizeof(sqSSL*));
-        for (int i = handleMax; i < handleMax + delta; i++) {
+        for (i = handleMax; i < handleMax + delta; i++)*^M*
             handleBuf[i] = NULL;
-        }
         handleMax += delta;
     }

On Wed, Sep 7, 2016 at 9:21 AM, GitHub <noreply at github.com> wrote:

>
>   Branch: refs/heads/Cog
>   Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
>   Commit: b14f85f17051df09c7c7b94d03aef3b0207bef00
>       https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/
> b14f85f17051df09c7c7b94d03aef3b0207bef00
>   Author: Tobias Pape <tobias at netshed.de>
>   Date:   2016-09-07 (Wed, 07 Sep 2016)
>
>   Changed paths:
>     M platforms/unix/plugins/SqueakSSL/sqUnixOpenSSL.c
>
>   Log Message:
>   -----------
>   [SqueakSSL] fix endless recursion on failes connect
>
> Because returning -1 here is actually saying "need more data"
>
>
>
>


-- 
_,,,^..^,,,_
best, Eliot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20160907/5a5acfff/attachment.htm