[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] ca7e8d: Change platform sources to refer to _WIN32 & _WIN6...

K K Subbu kksubbu.ml at gmail.com
Thu May 18 05:13:12 UTC 2017


On Thursday 18 May 2017 05:23 AM, Eliot Miranda wrote:
> Note that attribute 1001 was not changed and still answers 'Win32'. i
> only changed 1005, the windowing system name, to answer 'Windows'
> instead of 'Win32'.  I did this because the only use of parameter 1005 I
> could find was this one:
>
> HandMorph>>compositionWindowManager
> CompositionWindowManager ifNotNil: [^CompositionWindowManager].
> Smalltalk platformName = 'Win32'

Thanks for the clarification. You're right.

> BTW, I think the code would read much better as
>
> HandMorph>>compositionWindowManager
> CompositionWindowManager ifNotNil: [^CompositionWindowManager].
> Smalltalk windowSystemName = 'Windows'

I agree. Window API should be differentiated from the platform API in 
general.

Regards .. Subbu


More information about the Vm-dev mailing list