[Vm-dev] About SQFile's fileSize field
David T. Lewis
lewis at mail.msen.com
Thu Oct 12 00:40:44 UTC 2017
Following up on my own post, I just did a quick check of OSProcessPlugin
and I do not think that any changes are needed there, so no worries :-)
On Wed, Oct 11, 2017 at 05:34:29PM -0400, David T. Lewis wrote:
> Just FYI, the data structure is used in OSProcessPlugin also, so changes
> may be needed there too. That would be in Slang, not platform sources.
> > I went ahead a bit, removed the field, updated the sources, and compiled a
> > VM with the changes. It works fine on linux. I've updated the windows and
> > mac files too, but I can't test those.
> > There are some remaining references to the removed field in the RiscOS
> > platforms file, but I don't really know what to do with that. The code
> > seems to be using platform specific calls to implement the plugin, which
> > is unusual, but may be more efficient than the generic C implementation.
> > Anyway, the code is on github. I'll create a pull request once someone
> > says something about the idea.
> > Levente
> > 
> > https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/Cog...smalltalking:Cog
> > On Tue, 10 Oct 2017, Levente Uzonyi wrote:
> >> Hi All,
> >> The SQFile struct has a field named fileSize, which is used to
> >> cache
> >> the size of the file when such property makes sense.
> >> This caching behavior seems unnecessary, and it causes synchronization
> >> problems between multiple SQFile structures of a single file. The latter
> >> could be worked around by updating the cached value more often, but I
> >> was
> >> wondering why is the value cached at all. Does anyone know?
> >> Levente
> >> 
> >> https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/platforms/Cross/plugins/FilePlugin/FilePlugin.h
> >> 
> >> https://github.com/OpenSmalltalk/opensmalltalk-vm/blob/Cog/platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c
More information about the Vm-dev