[Vm-dev] [Pharo-dev] Change Pharo window icon

[Vincent.Blondeau at lamresearch.com]

From: Eliot Miranda [mailto:eliot.miranda at gmail.com]
Sent: Friday, April 13, 2018 17:25
To: Open Smalltalk Virtual Machine Development Discussion <vm-dev at lists.squeakfoundation.org>
Cc: Blondeau, Vincent <Vincent.Blondeau at lamresearch.com>
Subject: Re: [Pharo-dev] Change Pharo window icon



On Fri, Apr 13, 2018 at 5:23 PM, Eliot Miranda <eliot.miranda at gmail.com<mailto:eliot.miranda at gmail.com>> wrote:
Hi Vincent,
    I've replied to the vm-dev list (Open Smalltalk Virtual Machine Development Discussion <vm-dev at lists.squeakfoundation.org<mailto:vm-dev at lists.squeakfoundation.org>>).  For some reason your post went to vm-dev-bounces at lists.squeakfoundation.org<mailto:vm-dev-bounces at lists.squeakfoundation.org>.

On Fri, Apr 13, 2018 at 4:45 PM, <Vincent.Blondeau at lamresearch.com<mailto:Vincent.Blondeau at lamresearch.com>> wrote:
Hi,

In the way to change dynamically the icon of the main window, I am adding a primitive in the HostWindow VM Plugin.
So, I implemented the primitive call on Pharo side: https://github.com/pharo-project/pharo/pull/1198<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pharo-2Dproject_pharo_pull_1198&d=DwMFaQ&c=RWI7EqL8K9lqtga8KxgfzvOYoob76EZWE0yAO85PVMQ&r=kIZIYXBAA3fhM7P5HOuTC5w6mnEApTfXPTq3lR34ZiY&m=T2h2oTfP-hjK-O_wR-qFrIY3qz2fgVG6zdNjaz8MRAA&s=gfXRMpUKZ2FxuAIPZo6r8YNDBVkdDQ1XsQ2irPGHXew&e=>
Modified the C plugin file: https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/248<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_OpenSmalltalk_opensmalltalk-2Dvm_pull_248&d=DwMFaQ&c=RWI7EqL8K9lqtga8KxgfzvOYoob76EZWE0yAO85PVMQ&r=kIZIYXBAA3fhM7P5HOuTC5w6mnEApTfXPTq3lR34ZiY&m=T2h2oTfP-hjK-O_wR-qFrIY3qz2fgVG6zdNjaz8MRAA&s=bG-0Z8uvn4p-t17EKgAGfEfksOX-1WAN2tZsyuLNa78&e=> (only the windows version for now)

Be careful.  Unless you add stub definitions to unix and iOS files you may end up breaking the build.  Have you tested the build on iOS and a linux?

I looked.  You did the right thing (of course).  Forgive me!

Thanks Eliot! I just committed into VMMaker repository. What is the next step? Should I generate the C code from it and add it to the PR I made?

Vincent

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180414/d14d1206/attachment-0001.html>