[Vm-dev] [Pharo-dev] Change Pharo window icon

[Vincent.Blondeau at lamresearch.com]

Thank you Tim!
So, I just committed it, waiting for the CI.

Vincent

-----Original Message-----
From: Vm-dev [mailto:vm-dev-bounces at lists.squeakfoundation.org] On Behalf Of tim Rowledge
Sent: Saturday, April 14, 2018 13:05
To: Squeak Virtual Machine Development Discussion <vm-dev at lists.squeakfoundation.org>
Subject: Re: [Vm-dev] [Pharo-dev] Change Pharo window icon

 


> On 14-04-2018, at 12:32 PM, <Vincent.Blondeau at lamresearch.com> <Vincent.Blondeau at lamresearch.com> wrote:
> 
> Thanks Eliot! I just committed into VMMaker repository. What is the next step? Should I generate the C code from it and add it to the PR I made?

I assume you've generated the code and built it to test? As long as that is all ok there's no need that I know of to do anything else. The VMMaker will make the C code and next time a version (or whatever git calls them) is generated and committed it will be there.

And, by the way, good catch. John & I didn't think of that need when we did the original ghost window stuff.

tim
--
tim Rowledge; tim at rowledge.org; https://urldefense.proofpoint.com/v2/url?u=http-3A__www.rowledge.org_tim&d=DwIGaQ&c=RWI7EqL8K9lqtga8KxgfzvOYoob76EZWE0yAO85PVMQ&r=kIZIYXBAA3fhM7P5HOuTC5w6mnEApTfXPTq3lR34ZiY&m=DexW8uqYxZhcMR6sPO0isfgiyoUgSEWUN277yrx8jHU&s=KDCl2-UE6trPKzOnr2YwCHhmMC6zjZ_32i5T1GVj_04&e=
Useful Latin Phrases:- Visne saltare? Viam Latam Fungosam scio = Do you want to dance? I know the Funky Broadway.