[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Add accurate check for console stdio + add associated primitive (#254)

Eliot Miranda notifications at github.com
Tue Apr 24 03:08:28 UTC 2018


Hi Vincent, in isStdioDescriptorATTY at line 898 there is no guard to check if pGetFileInformationByHandleEx has already been fetched.  The code needs to be something like

	static pfnGetFileInformationByHandleEx pGetFileInformationByHandleEx = NULL;

	if (! pGetFileInformationByHandleEx) {
		pGetFileInformationByHandleEx = (pfnGetFileInformationByHandleEx)
 			GetProcAddress(GetModuleHandle(TEXT("kernel32.dll")),
						"GetFileInformationByHandleEx");
		if (pGetFileInformationByHandleEx == NULL)  return -2;
	}

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/254#issuecomment-383789148
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20180423/37583e31/attachment.html>


More information about the Vm-dev mailing list