[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] 2f9165: 274 primitiveFileStdioHandles() fails to return ni...

[GitHub]

  Branch: refs/heads/Cog
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: 2f91655ba5c449dc5b6da19b1d66251ab3d27908
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/2f91655ba5c449dc5b6da19b1d66251ab3d27908
  Author: AlistairGrant <akgrant0710 at gmail.com>
  Date:   2018-08-12 (Sun, 12 Aug 2018)

  Changed paths:
    M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c
    M platforms/RiscOS/plugins/FilePlugin/sqFilePluginBasicPrims.c
    M platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c
    M src/plugins/FilePlugin/FilePlugin.c

  Log Message:
  -----------
  274 primitiveFileStdioHandles() fails to return nil if stdio file is not available

According to the comment for primitiveFileStdioHandles():

Answer an Array of file handles for standard in, standard out and
standard error, with nil in entries that are unvailable, e.g. because
the platform does not provide standard error, etc.

However, on Windows in practice an array of sqFile entries with null
handles is returned. The image is unable to distinguish between valid
and invalid entries since sqFile is private to the VM.

- Modify sqWin32FilePrims.c() to set the valid mask correctly.
- Modify primitiveFileStdioHandles() to treat a mask of 0 as
  successfully determining that no stdio is available (a normal case
  on Windows).
  A validMask of -1 is treated as an error.
- Update comments to reflect changed behaviour


  Commit: a0869bef41032f2586c60de6ca73d0aeb9aa0478
      https://github.com/OpenSmalltalk/opensmalltalk-vm/commit/a0869bef41032f2586c60de6ca73d0aeb9aa0478
  Author: akgrant43 <akgrant at gmail.com>
  Date:   2018-08-13 (Mon, 13 Aug 2018)

  Changed paths:
    M platforms/Cross/plugins/FilePlugin/sqFilePluginBasicPrims.c
    M platforms/RiscOS/plugins/FilePlugin/sqFilePluginBasicPrims.c
    M platforms/win32/plugins/FilePlugin/sqWin32FilePrims.c
    M src/plugins/FilePlugin/FilePlugin.c

  Log Message:
  -----------
  Merge pull request #276 from akgrant43/Issue274

274 primitiveFileStdioHandles() fails to return nil if stdio file is not available


Compare: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/a28a7546d6dc...a0869bef4103
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.