[Vm-dev] Passed: OpenSmalltalk/opensmalltalk-vm#1531 (Cog - 14b6d36)

Travis CI builds at travis-ci.org
Mon Dec 10 15:11:19 UTC 2018

Build Update for OpenSmalltalk/opensmalltalk-vm

Build: #1531
Status: Passed

Duration: 55 mins and 11 secs
Commit: 14b6d36 (Cog)
Author: Nicolas Cellier
Message: Fix suspiscious logical construction

In code we find this flag:

    #define SOCK_BOUND_UDP     0x00040000

and test of this flag in socket state:

    if(pss->sockState & SOCK_BOUND_UDP)

We also find the negation:

    if(!pss->sockState & SOCK_BOUND_UDP)

But there is a precedenc eproblem in above expression, as reported by the compiler

    ../../platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c:872:8: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
        if(!pss->sockState & SOCK_BOUND_UDP) {
           ^               ~
    ../../platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c:872:8: note: add parentheses after the '!' to evaluate the bitwise operator first
        if(!pss->sockState & SOCK_BOUND_UDP) {
            (                              )
    ../../platforms/win32/plugins/SocketPlugin/sqWin32NewNet.c:872:8: note: add parentheses around left hand side expression to silence this warning
        if(!pss->sockState & SOCK_BOUND_UDP) {
           (              )

Above code is interpreted as  `if( (!pss->sockState) & SOCK_BOUND_UDP)` which does not mean much...

Please, read C compiler warnings, they are a companion tool !

View the changeset: https://github.com/OpenSmalltalk/opensmalltalk-vm/compare/32c4b7972e05...14b6d3645d44

View the full build log and details: https://travis-ci.org/OpenSmalltalk/opensmalltalk-vm/builds/465986460?utm_medium=notification&utm_source=email


You can unsubscribe from build emails from the OpenSmalltalk/opensmalltalk-vm repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=8795279&utm_medium=notification&utm_source=email.
Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification&utm_source=email.
Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181210/dda5acc4/attachment-0001.html>

More information about the Vm-dev mailing list