[Vm-dev] B3DAccelerator on 64bits

[Nicolas Cellier]

Hi,
Compiler warnings on 64bits for B3DAccelerator Plugin makes me think it
can't work:

clang-5.0: warning: argument unused during compilation: '-mdll'
[-Wunused-command-line-argument]
../../platforms/Cross/plugins/B3DAcceleratorPlugin/sqOpenGLRenderer.c:103:19:
warning: implicit declaration of function 'getImageName' is invalid in C99
[-Wimplicit-function-declaration]
                strcpy(fileName,getImageName());
                                ^
../../platforms/Cross/plugins/B3DAcceleratorPlugin/sqOpenGLRenderer.c:103:19:
warning: incompatible integer to pointer conversion passing 'int' to
parameter of type 'const char *' [-Wint-conversion]
                strcpy(fileName,getImageName());
                                ^~~~~~~~~~~~~~
/usr/x86_64-w64-mingw32/sys-root/mingw/include/string.h:61:77: note:
passing argument to parameter '_Source' here
  char * __cdecl strcpy(char * __restrict__ _Dest,const char * __restrict__
_Source);

We are going to pass an address on 32bits because getImageName() has not
been declared and will be considered as returning an int...
If the address were on low end of address space it could eventually work,
but we can't depend on such property.

It's vital that we properly declare function prototypes (preferably by
using ad hoc header) and all  [-Wimplicit-function-declaration] reports
deserve greater attention.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181211/b555a576/attachment-0001.html>