[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] Check sanity of curled gzip data (#326)

Gabriel Omar Cotelli notifications at github.com
Fri Dec 21 13:34:26 UTC 2018


gcotelli commented on this pull request.



> @@ -52,6 +52,14 @@ else
 				exit
 			fi
 			curl -L "$URL" -o "$LATESTVM"
+			# bug in bintray: on a 404 error,
+			# it will return a 200 with garbage data
+			if [[ $(file "$LATESTVM" | grep 'gzip compressed data') ]]; then 
+			  tar xzf "$LATESTVM"
+			else
+			  echo No gzip data at "$URL"
+			  exit
+			fi
 			tar xzf "$LATESTVM"

This line seems to be duplicated. It's already contained in the if 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/326#pullrequestreview-187394733
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squeakfoundation.org/pipermail/vm-dev/attachments/20181221/797fb325/attachment.html>


More information about the Vm-dev mailing list