[Vm-dev] [OpenSmalltalk/opensmalltalk-vm] b52caa: Fix sqWin32Security.c UNICODE problems

GitHub noreply at github.com
Thu Dec 27 15:50:41 UTC 2018

  Branch: refs/heads/win64_cleanups
  Home:   https://github.com/OpenSmalltalk/opensmalltalk-vm
  Commit: b52caab76f7f6b91c1f16d9037e0b0a43d968176
  Author: Nicolas Cellier <nicolas.cellier.aka.nice at gmail.com>
  Date:   2018-12-27 (Thu, 27 Dec 2018)

  Changed paths:
    M platforms/win32/plugins/SecurityPlugin/sqWin32Security.c

  Log Message:
  Fix sqWin32Security.c UNICODE problems

We cannot pass a TCHAR * to a function expecting a WCHAR *, or the compiler logically barks.
`isAccessiblePathName` takes a WCHAR * parameter
`fromSqueak` answers a TCHAR *, which is currently a char * (because UNICODE is undefined).

We want to be able to query internationalized path name, then the best (portable) thing to do is stick to UTF-8.
We thus now interpret the pathName/fileName as UTF8-encoded in the authorization query primitives.

NOTE: no effort is attempted to handle long path names here.

      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

More information about the Vm-dev mailing list